Bug 173088 - WebAssembly: We should only create wrappers for functions that can be exported
Summary: WebAssembly: We should only create wrappers for functions that can be exported
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-07 21:43 PDT by Keith Miller
Modified: 2017-06-08 12:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (184.73 KB, patch)
2017-06-07 21:48 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (185.74 KB, patch)
2017-06-07 22:42 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (185.75 KB, patch)
2017-06-07 22:43 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (186.44 KB, patch)
2017-06-08 11:35 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-06-07 21:43:14 PDT 
WebAssembly: We should only create wrappers for functions that can be exported
Comment 1 Keith Miller 2017-06-07 21:48:51 PDT 
Created attachment 312277 [details]
Patch
Comment 2 Saam Barati 2017-06-07 22:36:50 PDT 
Comment on attachment 312277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312277&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        can actually be exported. It appears to be a ~2.5% speedup on WasmBench.

nice

> Source/JavaScriptCore/ChangeLog:11
> +        This patch also removes most of the old testWasmModuleFunctions api from the jsc CLI.

🎉

Also, why "most" here? It looks like you're removing it all

> Tools/Scripts/run-jsc-stress-tests:1204
> +    if !$quickMode

Do you want to give the specTests/Emscripten the same treatment?
Comment 3 Keith Miller 2017-06-07 22:41:00 PDT 
Comment on attachment 312277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312277&action=review

>> Source/JavaScriptCore/ChangeLog:11
>> +        This patch also removes most of the old testWasmModuleFunctions api from the jsc CLI.
> 
> 🎉
> 
> Also, why "most" here? It looks like you're removing it all

The others were not removed but rather updated.

>> Tools/Scripts/run-jsc-stress-tests:1204
>> +    if !$quickMode
> 
> Do you want to give the specTests/Emscripten the same treatment?

Done!
Comment 4 Keith Miller 2017-06-07 22:42:21 PDT 
Created attachment 312278 [details]
Patch for landing
Comment 5 Keith Miller 2017-06-07 22:43:10 PDT 
Created attachment 312279 [details]
Patch for landing
Comment 6 Keith Miller 2017-06-07 22:43:32 PDT 
Comment on attachment 312277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312277&action=review

>> Source/JavaScriptCore/ChangeLog:9
>> +        can actually be exported. It appears to be a ~2.5% speedup on WasmBench.
> 
> nice

Whoops, I should have mentioned that it's only 2.5% on compile times.
Comment 7 Keith Miller 2017-06-08 11:35:01 PDT 
Created attachment 312328 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-06-08 12:13:57 PDT 
Comment on attachment 312328 [details]
Patch for landing

Clearing flags on attachment: 312328

Committed r217942: <http://trac.webkit.org/changeset/217942>
Comment 9 WebKit Commit Bot 2017-06-08 12:13:59 PDT 
All reviewed patches have been landed.  Closing bug.