Bug 173080 - Add High Sierra support to WebKit tools
Summary: Add High Sierra support to WebKit tools
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-07 15:52 PDT by Alexey Proskuryakov
Modified: 2017-06-07 21:47 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (261.83 KB, patch)
2017-06-07 15:56 PDT, Alexey Proskuryakov 		dbates: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-06-07 15:52:09 PDT 
Add macOS High Sierra support to WebKit tools.
Comment 1 Alexey Proskuryakov 2017-06-07 15:56:50 PDT 
Created attachment 312248 [details]
proposed patch
Comment 2 Ryan Haddad 2017-06-07 16:01:17 PDT 
Comment on attachment 312248 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312248&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:698
> +            'HishSierra': 'HIGHSIERRA',

"HishSierra" should be "HighSierra"
Comment 3 Alexey Proskuryakov 2017-06-07 16:03:28 PDT 
Comment on attachment 312248 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312248&action=review

>> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:698
>> +            'HishSierra': 'HIGHSIERRA',
> 
> "HishSierra" should be "HighSierra"

Thank you, fixed locally.
Comment 4 Daniel Bates 2017-06-07 19:56:04 PDT 
Comment on attachment 312248 [details]
proposed patch

rs=me
Comment 5 Alexey Proskuryakov 2017-06-07 21:43:40 PDT 
Committed <http://trac.webkit.org/r217920>
Comment 6 Alexey Proskuryakov 2017-06-07 21:47:09 PDT 
But mostly <http://trac.webkit.org/r217922>.