Bug 173079 - Add a borderless mode to <attachment>, and make it respect its layout size
Summary: Add a borderless mode to <attachment>, and make it respect its layout size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-07 15:50 PDT by Tim Horton
Modified: 2017-06-08 11:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.04 KB, patch)
2017-06-07 15:50 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-06-07 15:50:23 PDT 
Add a borderless mode to <attachment>, and make it respect its layout size
Comment 1 Tim Horton 2017-06-07 15:50:43 PDT 
Created attachment 312246 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-06-07 17:13:51 PDT 
Comment on attachment 312246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312246&action=review

> Source/WebCore/rendering/RenderAttachment.cpp:77
> +    if (style().appearance() == BorderlessAttachmentPart)
> +        return false;
> +    return m_shouldDrawBorder;

Can m_shouldDrawBorder just be set to false for this type of attachment?
Comment 3 Tim Horton 2017-06-08 10:37:15 PDT 
Comment on attachment 312246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312246&action=review

>> Source/WebCore/rendering/RenderAttachment.cpp:77
>> +    return m_shouldDrawBorder;
> 
> Can m_shouldDrawBorder just be set to false for this type of attachment?

Currently DragController just smacks shouldDrawBorder with its own true/false (could be made a SetForScope). Also, I'm not totally sure where to do that (where to know when style is done resolving each time, in order to update this)? Thoughts?
Comment 4 WebKit Commit Bot 2017-06-08 11:08:52 PDT 
Comment on attachment 312246 [details]
Patch

Clearing flags on attachment: 312246

Committed r217937: <http://trac.webkit.org/changeset/217937>
Comment 5 WebKit Commit Bot 2017-06-08 11:08:54 PDT 
All reviewed patches have been landed.  Closing bug.