Bug 173079 – Add a borderless mode to <attachment>, and make it respect its layout size

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Add a borderless mode to <attachment>, and make it respect its layout size

[Tim Horton]

Created attachment 312246 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 312246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312246&action=review

> Source/WebCore/rendering/RenderAttachment.cpp:77
> +    if (style().appearance() == BorderlessAttachmentPart)
> +        return false;
> +    return m_shouldDrawBorder;

Can m_shouldDrawBorder just be set to false for this type of attachment?

[Tim Horton]

Comment on attachment 312246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312246&action=review

>> Source/WebCore/rendering/RenderAttachment.cpp:77
>> +    return m_shouldDrawBorder;
> 
> Can m_shouldDrawBorder just be set to false for this type of attachment?

Currently DragController just smacks shouldDrawBorder with its own true/false (could be made a SetForScope). Also, I'm not totally sure where to do that (where to know when style is done resolving each time, in order to update this)? Thoughts?

[WebKit Commit Bot]

Comment on attachment 312246 [details]
Patch

Clearing flags on attachment: 312246

Committed r217937: <http://trac.webkit.org/changeset/217937>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.