Bug 173076 - bmalloc: memory APIs don't need to be heap data members
Summary: bmalloc: memory APIs don't need to be heap data members
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-07 15:04 PDT by Geoffrey Garen
Modified: 2017-06-09 10:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.08 KB, patch)
2017-06-07 15:06 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (7.09 KB, patch)
2017-06-07 15:12 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (7.16 KB, patch)
2017-06-07 15:20 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (7.02 KB, patch)
2017-06-07 15:24 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (7.41 KB, patch)
2017-06-07 15:35 PDT, Geoffrey Garen 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2017-06-07 15:04:20 PDT 
bmalloc: memory APIs don't need to be heap data members
Comment 1 Geoffrey Garen 2017-06-07 15:06:54 PDT 
Created attachment 312237 [details]
Patch
Comment 2 Geoffrey Garen 2017-06-07 15:12:39 PDT 
Created attachment 312238 [details]
Patch
Comment 3 Geoffrey Garen 2017-06-07 15:20:11 PDT 
Created attachment 312240 [details]
Patch
Comment 4 Geoffrey Garen 2017-06-07 15:24:00 PDT 
Created attachment 312242 [details]
Patch
Comment 5 Geoffrey Garen 2017-06-07 15:35:22 PDT 
Created attachment 312244 [details]
Patch
Comment 6 Geoffrey Garen 2017-06-07 21:05:45 PDT 
Committed r217918: <http://trac.webkit.org/changeset/217918>
Comment 7 Darin Adler 2017-06-09 10:06:29 PDT 
Comment on attachment 312244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312244&action=review

> Source/bmalloc/bmalloc/AvailableMemory.h:52
> +    auto memoryUse = memoryStatus();
> +    return memoryUse.memoryFootprint;

Nicer without a local variable.

> Source/bmalloc/bmalloc/AvailableMemory.h:58
> +    auto memoryUse = memoryStatus();
> +    return memoryUse.percentAvailableMemoryInUse;

Ditto.