WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173075
Restrict the regress-173035.js test to only run on Darwin x86-64.
https://bugs.webkit.org/show_bug.cgi?id=173075
Summary
Restrict the regress-173035.js test to only run on Darwin x86-64.
Mark Lam
Reported
2017-06-07 14:57:26 PDT
This is because the 32-bit x86 build will fail to mmap the 0x3f900000 bytes that this test will require to succeed. Here's an example of this failure:
https://build.webkit.org/builders/Apple%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/866/steps/webkit-32bit-jsc-test/logs/stdio
Since the issue is due to allocation of a very large amount of memory, the test will probably fail on iOS and other platforms as well. Hence, we should just skip this test for any platforms that is not Darwin x86-64.
Attachments
proposed patch.
(1.50 KB, patch)
2017-06-07 15:00 PDT
,
Mark Lam
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2017-06-07 15:00:11 PDT
Created
attachment 312235
[details]
proposed patch.
WebKit Commit Bot
Comment 2
2017-06-07 15:39:09 PDT
Comment on
attachment 312235
[details]
proposed patch. Clearing flags on attachment: 312235 Committed
r217909
: <
http://trac.webkit.org/changeset/217909
>
WebKit Commit Bot
Comment 3
2017-06-07 15:39:11 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug