NEW173065
Clean-up: Move inline methods of RenderObject and RenderElement into *Inlines.h files 
https://bugs.webkit.org/show_bug.cgi?id=173065
Summary Clean-up: Move inline methods of RenderObject and RenderElement into *Inlines...
Jer Noble
Reported 2017-06-07 10:28:07 PDT
Clean-up: Move inline methods of RenderObject and RenderElement into *Inlines.h files
Attachments
Patch (91.10 KB, patch)
2017-06-07 10:49 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (91.20 KB, patch)
2017-06-07 11:13 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (93.62 KB, patch)
2017-06-07 14:21 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (93.74 KB, patch)
2017-06-27 14:11 PDT, Jer Noble 		mjs: review-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-06-07 10:49:13 PDT
Created attachment 312196 [details] Patch
Jer Noble
Comment 2 2017-06-07 11:13:29 PDT
Created attachment 312202 [details] Patch
Build Bot
Comment 3 2017-06-07 11:16:04 PDT
Attachment 312202 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderObjectInlines.h:172: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WebCore/rendering/RenderObject.cpp:2034: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 78 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 4 2017-06-07 14:21:47 PDT
Created attachment 312225 [details] Patch
Darin Adler
Comment 5 2017-06-25 17:57:51 PDT
Comment on attachment 312225 [details] Patch Please rebase.
Jer Noble
Comment 6 2017-06-27 14:11:21 PDT
Created attachment 313939 [details] Patch
Build Bot
Comment 7 2017-06-27 14:13:43 PDT
Attachment 313939 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderObject.cpp:2034: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/RenderObjectInlines.h:172: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 2 in 83 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 8 2020-05-30 19:37:42 PDT
Comment on attachment 313939 [details] Patch Probably good for build speed, but this version of this patch no longer applies.
Note You need to log in before you can comment on or make changes to this bug.