Bug 173055 - Add Charlie Turner as contributor
Summary: Add Charlie Turner as contributor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-07 06:01 PDT by Charlie Turner
Modified: 2017-06-07 08:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2017-06-07 06:10 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2017-06-07 06:01:12 PDT 
Carlos López (Igalia) suggested I add myself to the contributors.json file in IM message to make some additions to the Wiki.
Comment 1 Charlie Turner 2017-06-07 06:10:43 PDT 
Created attachment 312179 [details]
Patch
Comment 2 Build Bot 2017-06-07 06:12:57 PDT 
Attachment 312179 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Alberto Lopez Perez 2017-06-07 07:39:21 PDT 
Comment on attachment 312179 [details]
Patch

Looks good to me. I didn't knew about this Tools/Scripts/validate-committer-lists --canonicalize tool .. nice

Let's see if CQ can handle this despite of the style warning.
Comment 4 WebKit Commit Bot 2017-06-07 08:08:17 PDT 
Comment on attachment 312179 [details]
Patch

Clearing flags on attachment: 312179

Committed r217883: <http://trac.webkit.org/changeset/217883>
Comment 5 WebKit Commit Bot 2017-06-07 08:08:19 PDT 
All reviewed patches have been landed.  Closing bug.