RESOLVED FIXED 173047
[preload] Mandatory `as` value and related spec alignments 
https://bugs.webkit.org/show_bug.cgi?id=173047
Summary [preload] Mandatory `as` value and related spec alignments
Yoav Weiss
Reported 2017-06-07 01:30:22 PDT
[preload] Mandatory `as` value and related spec alignments
Attachments
Patch (49.56 KB, patch)
2017-06-07 01:48 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (49.32 KB, patch)
2017-06-07 01:53 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (1.09 MB, application/zip)
2017-06-07 02:30 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.29 MB, application/zip)
2017-06-07 02:36 PDT, Build Bot 		no flags
Details
Patch (50.50 KB, patch)
2017-06-07 03:00 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2017-06-07 01:48:09 PDT
Created attachment 312169 [details] Patch
Yoav Weiss
Comment 2 2017-06-07 01:53:59 PDT
Created attachment 312171 [details] Patch
Build Bot
Comment 3 2017-06-07 02:30:43 PDT
Comment on attachment 312171 [details] Patch Attachment 312171 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3886738 New failing tests: http/tests/fetch/redirectmode-and-preload.html
Build Bot
Comment 4 2017-06-07 02:30:45 PDT
Created attachment 312173 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 5 2017-06-07 02:36:24 PDT
Comment on attachment 312171 [details] Patch Attachment 312171 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3886743 New failing tests: http/tests/fetch/redirectmode-and-preload.html
Build Bot
Comment 6 2017-06-07 02:36:26 PDT
Created attachment 312174 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Yoav Weiss
Comment 7 2017-06-07 03:00:40 PDT
Created attachment 312175 [details] Patch
Yoav Weiss
Comment 8 2017-06-08 21:55:39 PDT
Comment on attachment 312175 [details] Patch Thanks for reviewing! :)
WebKit Commit Bot
Comment 9 2017-06-08 22:25:05 PDT
Comment on attachment 312175 [details] Patch Clearing flags on attachment: 312175 Committed r217962: <http://trac.webkit.org/changeset/217962>
WebKit Commit Bot
Comment 10 2017-06-08 22:25:07 PDT
All reviewed patches have been landed. Closing bug.
Don Olmstead
Comment 11 2017-06-09 11:56:18 PDT
(In reply to WebKit Commit Bot from comment #9) > Comment on attachment 312175 [details] > Patch > > Clearing flags on attachment: 312175 > > Committed r217962: <http://trac.webkit.org/changeset/217962> This patch breaks !ENABLE(VIDEO_TRACK) builds. The issue is that the #if ENABLE(VIDEO_TRACK) contains the closing parenthesis for the statement. Can we just move the conditional above to fix?
Yoav Weiss
Comment 12 2017-06-09 21:49:53 PDT
(In reply to Don Olmstead from comment #11) > (In reply to WebKit Commit Bot from comment #9) > > Comment on attachment 312175 [details] > > Patch > > > > Clearing flags on attachment: 312175 > > > > Committed r217962: <http://trac.webkit.org/changeset/217962> > > This patch breaks !ENABLE(VIDEO_TRACK) builds. > > The issue is that the #if ENABLE(VIDEO_TRACK) contains the closing > parenthesis for the statement. Can we just move the conditional above to fix? https://bugs.webkit.org/show_bug.cgi?id=173221 should fix that build issue
Note You need to log in before you can comment on or make changes to this bug.