Bug 173047 - [preload] Mandatory `as` value and related spec alignments
Summary: [preload] Mandatory `as` value and related spec alignments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-07 01:30 PDT by Yoav Weiss
Modified: 2017-06-09 21:49 PDT (History)
12 users (show)

See Also:


Attachments
Patch (49.56 KB, patch)
2017-06-07 01:48 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Patch (49.32 KB, patch)
2017-06-07 01:53 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.09 MB, application/zip)
2017-06-07 02:30 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.29 MB, application/zip)
2017-06-07 02:36 PDT, Build Bot
no flags Details
Patch (50.50 KB, patch)
2017-06-07 03:00 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2017-06-07 01:30:22 PDT
[preload] Mandatory `as` value and related spec alignments
Comment 1 Yoav Weiss 2017-06-07 01:48:09 PDT
Created attachment 312169 [details]
Patch
Comment 2 Yoav Weiss 2017-06-07 01:53:59 PDT
Created attachment 312171 [details]
Patch
Comment 3 Build Bot 2017-06-07 02:30:43 PDT
Comment on attachment 312171 [details]
Patch

Attachment 312171 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3886738

New failing tests:
http/tests/fetch/redirectmode-and-preload.html
Comment 4 Build Bot 2017-06-07 02:30:45 PDT
Created attachment 312173 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-06-07 02:36:24 PDT
Comment on attachment 312171 [details]
Patch

Attachment 312171 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3886743

New failing tests:
http/tests/fetch/redirectmode-and-preload.html
Comment 6 Build Bot 2017-06-07 02:36:26 PDT
Created attachment 312174 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Yoav Weiss 2017-06-07 03:00:40 PDT
Created attachment 312175 [details]
Patch
Comment 8 Yoav Weiss 2017-06-08 21:55:39 PDT
Comment on attachment 312175 [details]
Patch

Thanks for reviewing! :)
Comment 9 WebKit Commit Bot 2017-06-08 22:25:05 PDT
Comment on attachment 312175 [details]
Patch

Clearing flags on attachment: 312175

Committed r217962: <http://trac.webkit.org/changeset/217962>
Comment 10 WebKit Commit Bot 2017-06-08 22:25:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Don Olmstead 2017-06-09 11:56:18 PDT
(In reply to WebKit Commit Bot from comment #9)
> Comment on attachment 312175 [details]
> Patch
> 
> Clearing flags on attachment: 312175
> 
> Committed r217962: <http://trac.webkit.org/changeset/217962>

This patch breaks !ENABLE(VIDEO_TRACK) builds.

The issue is that the #if ENABLE(VIDEO_TRACK) contains the closing parenthesis for the statement. Can we just move the conditional above to fix?
Comment 12 Yoav Weiss 2017-06-09 21:49:53 PDT
(In reply to Don Olmstead from comment #11)
> (In reply to WebKit Commit Bot from comment #9)
> > Comment on attachment 312175 [details]
> > Patch
> > 
> > Clearing flags on attachment: 312175
> > 
> > Committed r217962: <http://trac.webkit.org/changeset/217962>
> 
> This patch breaks !ENABLE(VIDEO_TRACK) builds.
> 
> The issue is that the #if ENABLE(VIDEO_TRACK) contains the closing
> parenthesis for the statement. Can we just move the conditional above to fix?

https://bugs.webkit.org/show_bug.cgi?id=173221 should fix that build issue