[preload] Mandatory `as` value and related spec alignments
Created attachment 312169 [details] Patch
Created attachment 312171 [details] Patch
Comment on attachment 312171 [details] Patch Attachment 312171 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3886738 New failing tests: http/tests/fetch/redirectmode-and-preload.html
Created attachment 312173 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 312171 [details] Patch Attachment 312171 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3886743 New failing tests: http/tests/fetch/redirectmode-and-preload.html
Created attachment 312174 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 312175 [details] Patch
Comment on attachment 312175 [details] Patch Thanks for reviewing! :)
Comment on attachment 312175 [details] Patch Clearing flags on attachment: 312175 Committed r217962: <http://trac.webkit.org/changeset/217962>
All reviewed patches have been landed. Closing bug.
(In reply to WebKit Commit Bot from comment #9) > Comment on attachment 312175 [details] > Patch > > Clearing flags on attachment: 312175 > > Committed r217962: <http://trac.webkit.org/changeset/217962> This patch breaks !ENABLE(VIDEO_TRACK) builds. The issue is that the #if ENABLE(VIDEO_TRACK) contains the closing parenthesis for the statement. Can we just move the conditional above to fix?
(In reply to Don Olmstead from comment #11) > (In reply to WebKit Commit Bot from comment #9) > > Comment on attachment 312175 [details] > > Patch > > > > Clearing flags on attachment: 312175 > > > > Committed r217962: <http://trac.webkit.org/changeset/217962> > > This patch breaks !ENABLE(VIDEO_TRACK) builds. > > The issue is that the #if ENABLE(VIDEO_TRACK) contains the closing > parenthesis for the statement. Can we just move the conditional above to fix? https://bugs.webkit.org/show_bug.cgi?id=173221 should fix that build issue