To help debugging
Created attachment 312162 [details] Patch
Attachment 312162 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/stats/rtcstats.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 312185 [details] Patch
Attachment 312185 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/stats/rtcstats.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 312185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312185&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1005 > + if (!m_statsTimestamp) > + m_statsTimestamp = report->timestamp_us(); > + else if (m_statsLogTimer.repeatInterval() == 1_s && (report->timestamp_us() - m_statsTimestamp) > 30000000) { > + callOnMainThread([protectedThis = makeRef(*this)] { > + protectedThis->m_statsLogTimer.augmentRepeatInterval(4_s); > + }); > + } Is there any reason to do this when RELEASE_LOG_DISABLED is defined?
(In reply to Eric Carlson from comment #5) > Comment on attachment 312185 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312185&action=review > > > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1005 > > + if (!m_statsTimestamp) > > + m_statsTimestamp = report->timestamp_us(); > > + else if (m_statsLogTimer.repeatInterval() == 1_s && (report->timestamp_us() - m_statsTimestamp) > 30000000) { > > + callOnMainThread([protectedThis = makeRef(*this)] { > > + protectedThis->m_statsLogTimer.augmentRepeatInterval(4_s); > > + }); > > + } > > Is there any reason to do this when RELEASE_LOG_DISABLED is defined? m_statsTimestamp is never used otherwise and the build system does not like that. This code will never be executed if RELEASE_LOG_DISABLED is defined anyway.
Comment on attachment 312185 [details] Patch Clearing flags on attachment: 312185 Committed r217888: <http://trac.webkit.org/changeset/217888>
All reviewed patches have been landed. Closing bug.
rdar://problem/32276496
Comment on attachment 312185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312185&action=review >>> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1005 >>> + } >> >> Is there any reason to do this when RELEASE_LOG_DISABLED is defined? > > m_statsTimestamp is never used otherwise and the build system does not like that. > This code will never be executed if RELEASE_LOG_DISABLED is defined anyway. The m_statsTimestamp declaration could be guarded with RELEASE_LOG_DISABLED as well.