RESOLVED FIXED 173044
[iOS WK1 WebThread] Do not call out to the main thread for device orientation. 
https://bugs.webkit.org/show_bug.cgi?id=173044
Summary [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
zalan
Reported 2017-06-06 19:14:26 PDT
cache it on the WebView instead.
Attachments
Patch (6.14 KB, patch)
2017-06-06 19:22 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.14 KB, patch)
2017-06-06 20:27 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-06-06 19:14:38 PDT
rdar://problem/32449338
zalan
Comment 2 2017-06-06 19:22:16 PDT
Created attachment 312155 [details] Patch
Tim Horton
Comment 3 2017-06-06 19:46:46 PDT
Comment on attachment 312155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312155&action=review > Source/WebKit/ios/ChangeLog:12 > + This patch ensures that we don't call out to the main tread from the Document's constructor. s/tread/thread/ > Source/WebKit/mac/WebView/WebFrame.mm:1290 > + WebView *webView = getWebView(self); > + [webView _setDeviceOrientation:[[webView _UIKitDelegateForwarder] deviceOrientation]]; Is it really OK to set this here if the getter is called on the web thread? should this be inside the WebThreadRun below?
zalan
Comment 4 2017-06-06 20:27:27 PDT
Created attachment 312159 [details] Patch
WebKit Commit Bot
Comment 5 2017-06-07 08:48:21 PDT
Comment on attachment 312159 [details] Patch Clearing flags on attachment: 312159 Committed r217884: <http://trac.webkit.org/changeset/217884>
WebKit Commit Bot
Comment 6 2017-06-07 08:48:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.