Bug 173032 – [WK2][Cocoa] Allow network process to bind addresses without webrtc extension

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

We initially though we would restrict webrtc access to clients that included the "com.apple.webkit.webrtc" extension. However, we have since decided that all WebKit clients should be able to use the webrtc transport layer, so no special extensions are needed to support this.

Simplify the implementation by removing these unnecessary checks.

[Radar WebKit Bug Importer]

<rdar://problem/32597426>

[Brent Fulgham]

Created attachment 312120 [details]
Patch

[Build Bot]

Comment on attachment 312120 [details]
Patch

Attachment 312120 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3884066

New failing tests:
webrtc/peer-connection-remote-audio-mute.html
webrtc/video-remote-mute.html
webrtc/multi-video.html
webrtc/datachannel/basic.html
webrtc/video.html
webrtc/video-mediastreamtrack-stats.html
webrtc/video-addTrack.html
webrtc/video-stats.html
webrtc/video-with-receiver.html
webrtc/datachannel/datachannel-gc.html
webrtc/datachannel/datachannel-stats.html
webrtc/connection-state.html
webrtc/no-port-zero-in-upd-candidates.html
webrtc/peer-connection-audio-unmute.html
webrtc/video-unmute.html
webrtc/video-disabled-black.html
webrtc/video-autoplay.html
webrtc/video-with-data-channel.html

[Build Bot]

Created attachment 312134 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Brent Fulgham]

Doh! I should have said ENABLE_WEB_RTC instead of ENABLE(WEB_RTC) in the sandbox template file.

[Brent Fulgham]

(In reply to Brent Fulgham from comment #5)
> Doh! I should have said ENABLE_WEB_RTC instead of ENABLE(WEB_RTC) in the
> sandbox template file.

Actually, it doesn't look like we support conditionalizing based on feature flags. I'll just remove the guard, since we always build Cocoa with this on, and no other port uses our sandbox profile.

[Brent Fulgham]

Created attachment 312145 [details]
Patch

[Brent Fulgham]

Created attachment 312146 [details]
Patch v3.

[Brent Fulgham]

Comment on attachment 312146 [details]
Patch v3.

There was an extra set of parenthesis in the rule.

[WebKit Commit Bot]

Comment on attachment 312146 [details]
Patch v3.

Clearing flags on attachment: 312146

Committed r217871: <http://trac.webkit.org/changeset/217871>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.