Bug 173019 - Update to slightly stricter rules for custom element names from more recent standard draft
Summary: Update to slightly stricter rules for custom element names from more recent s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 154907
  Show dependency treegraph
 
Reported: 2017-06-06 11:27 PDT by Darin Adler
Modified: 2017-06-06 15:38 PDT (History)
7 users (show)

See Also:


Attachments
Patch (9.62 KB, patch)
2017-06-06 11:34 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (9.68 KB, patch)
2017-06-06 12:10 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (12.52 KB, patch)
2017-06-06 12:58 PDT, Darin Adler
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2017-06-06 11:27:51 PDT
Update to slightly stricter rules for custom element names from more recent standard draft
Comment 1 Darin Adler 2017-06-06 11:34:25 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2017-06-06 11:34:54 PDT
Test coverage is not great.
Comment 3 Darin Adler 2017-06-06 12:10:46 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2017-06-06 12:58:29 PDT
Created attachment 312109 [details]
Patch
Comment 5 Darin Adler 2017-06-06 14:09:26 PDT
All the tests passed so now it’s definitely ready for review.
Comment 6 Ryosuke Niwa 2017-06-06 15:21:26 PDT
Comment on attachment 312109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312109&action=review

> Source/WebCore/dom/Document.cpp:1065
> +// https://www.w3.org/TR/custom-elements/#valid-custom-element-name

Please use https://html.spec.whatwg.org/#valid-custom-element-name instead since that's spec is obsolete.
Comment 7 Ryosuke Niwa 2017-06-06 15:21:57 PDT
Nice fix!
Comment 8 Radar WebKit Bug Importer 2017-06-06 15:22:11 PDT
<rdar://problem/32599604>
Comment 9 Darin Adler 2017-06-06 15:38:31 PDT
Committed r217864: <http://trac.webkit.org/changeset/217864>