Bug 173017 - Add missing <functional> includes
Summary: Add missing <functional> includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-06 11:16 PDT by Konstantin Tokarev
Modified: 2017-06-06 13:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.84 KB, patch)
2017-06-06 11:21 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff
Patch (3.94 KB, patch)
2017-06-06 11:24 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2017-06-06 11:16:50 PDT
They are required for compilation with GCC 7.
Comment 1 Konstantin Tokarev 2017-06-06 11:21:42 PDT
Created attachment 312092 [details]
Patch
Comment 2 Konstantin Tokarev 2017-06-06 11:24:18 PDT
Created attachment 312093 [details]
Patch
Comment 3 Yusuke Suzuki 2017-06-06 11:36:04 PDT
Comment on attachment 312093 [details]
Patch

r=me, nice.
Comment 4 WebKit Commit Bot 2017-06-06 12:51:13 PDT
Comment on attachment 312093 [details]
Patch

Rejecting attachment 312093 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 312093, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.webkit.org/git/WebKit
   8a6130a..de19104  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 217847 = 8a6130a5f71fef9fb8d525827139d2d1159bab26
r217848 = de19104ca342b5a86f9c2cf8023a252d1ccbc70a
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/3883297
Comment 5 Konstantin Tokarev 2017-06-06 13:10:05 PDT
Comment on attachment 312093 [details]
Patch

Clearing flags on attachment: 312093

Committed r217852: <http://trac.webkit.org/changeset/217852>
Comment 6 Konstantin Tokarev 2017-06-06 13:10:10 PDT
All reviewed patches have been landed.  Closing bug.