Bug 17301 - (Acid3) width/height media queries need to use the correct viewport and update on viewport-resize
Summary: (Acid3) width/height media queries need to use the correct viewport and updat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: Acid3
  Show dependency treegraph
 
Reported: 2008-02-10 17:32 PST by Dave Hyatt
Modified: 2008-02-21 16:16 PST (History)
0 users

See Also:


Attachments
Work in progress (15.40 KB, patch)
2008-02-10 17:43 PST, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch for review (21.92 KB, patch)
2008-02-21 14:58 PST, Dave Hyatt
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2008-02-10 17:32:56 PST
width/height media queries are always being evaluated with respect to the top-level frame.  This is wrong.
Comment 1 Dave Hyatt 2008-02-10 17:33:44 PST
This is the reason test 46 of Acid3 now fails.

Comment 2 Dave Hyatt 2008-02-10 17:43:48 PST
Created attachment 19055 [details]
Work in progress

This patch gets us further in the media queries section.  However, we fail once the viewport is dynamically resized.  In order to pass we'll need to record the fact that we are "viewport-sensitive" and force a complete style recalc on every resize (ugh).
Comment 3 Dave Hyatt 2008-02-21 14:58:53 PST
Created attachment 19262 [details]
Patch for review
Comment 4 Oliver Hunt 2008-02-21 16:01:32 PST
Comment on attachment 19262 [details]
Patch for review

r=me with a testcase -- text only if possible :D
Comment 5 Dave Hyatt 2008-02-21 16:16:34 PST
Fixed in r30466-7.