Bug 173009 – Exempt exclusively wall-powered devices from hardware codec requirement

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Exempt exclusively wall-powered devices from hardware codec requirement

[Jer Noble]

Created attachment 312094 [details]
Patch

[Darin Adler]

Comment on attachment 312094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312094&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:46
> +    RetainPtr<CFArrayRef> powerSourcesList = IOPSCopyPowerSourcesList(powerSourcesInfo.get());

Leak here. Forgot to call adoptCF.

[Jer Noble]

Created attachment 312112 [details]
Patch

[Jer Noble]

Created attachment 312113 [details]
Patch

[Jer Noble]

Created attachment 312137 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 312137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312137&action=review

> Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h:44
> +CFTypeRef IOPSCopyPowerSourcesInfo(void);
> +CFArrayRef IOPSCopyPowerSourcesList(CFTypeRef blob);
> +CFDictionaryRef IOPSGetPowerSourceDescription(CFTypeRef blob, CFTypeRef ps);

These shouldn't be in an #else block. We want the compiler to complain when there are changes to function signatures.

[Jer Noble]

Created attachment 312232 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 312232 [details]
Patch

Clearing flags on attachment: 312232

Committed r217906: <http://trac.webkit.org/changeset/217906>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.