Bug 173003 – [Win] Link errors on tag WebKit-603.3.4

• Status: NEW
• Component: WebKit Misc.

[Per Arne Vollan]

The symbols WebPreferences::allowsPageCacheWithWindowOpener and WebPreferences::setAllowsPageCacheWithWindowOpener are unresolved.

[Per Arne Vollan]

Created attachment 312086 [details]
Patch

[Per Arne Vollan]

<rdar://problem/32585333>

[Brent Fulgham]

Comment on attachment 312086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312086&action=review

r=me, but please figure out why the patch won't apply. :-)

> Source/WebKit/win/ChangeLog:10
> +        on trunk.

Hold on! This will break any existing clients that have linkage that knows about 'allowsPageCacheWithWindowOpener' and 'setAllowsPageCacheWithWindowOpener'. This shouldn't have been removed in Trunk. Instead, these should be No-op stubs.

Can you please make that change in trunk and we can make sure that correct change is merged back to 603 branch?

[Brent Fulgham]

Comment on attachment 312086 [details]
Patch

And by r=me, I obviously meant "r-". Sorry!

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 312086 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312086&action=review
> 
> r=me, but please figure out why the patch won't apply. :-)
> 
> > Source/WebKit/win/ChangeLog:10
> > +        on trunk.
> 
> Hold on! This will break any existing clients that have linkage that knows
> about 'allowsPageCacheWithWindowOpener' and
> 'setAllowsPageCacheWithWindowOpener'. This shouldn't have been removed in
> Trunk. Instead, these should be No-op stubs.
> 
> Can you please make that change in trunk and we can make sure that correct
> change is merged back to 603 branch?

It seems these methods existed in trunk for a only short period of time, and other methods have been added to the IWebPreferencesPrivate4 later. I don't think any clients are using these methods. Should we still add them?

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 312106 [details]
Patch

[Brent Fulgham]

(In reply to Per Arne Vollan from comment #5)
> > Can you please make that change in trunk and we can make sure that correct
> > change is merged back to 603 branch?
> 
> It seems these methods existed in trunk for a only short period of time, and
> other methods have been added to the IWebPreferencesPrivate4 later. I don't
> think any clients are using these methods. Should we still add them?

Oh! If we never shipped with those methods, then it is safe to remove them.

So let me completely reverse myself: Please DO remove them in 603 branch so that we don't create a stub that we have to maintain forever after!

We only want to add these stubs if the two methods were added as part of something that shipped to users. Based on the history you describe, that is not the case.

So I r+ your OLD patch, and r- THIS patch.

[Ahmad Saleem]

Seems to be AppleWin port related, I think we can mark this as 'RESOLVED CONFIGURATION CHANGED'.