Bug 172998 - LayoutTest media/fullscreen-api-enabled-media-with-presentation-mode.html is failing
Summary: LayoutTest media/fullscreen-api-enabled-media-with-presentation-mode.html is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-06 09:52 PDT by Ryan Haddad
Modified: 2020-06-29 14:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2020-06-29 13:24 PDT, Karl Rackler
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2020-06-29 14:05 PDT, Karl Rackler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-06-06 09:52:21 PDT
LayoutTest media/fullscreen-api-enabled-media-with-presentation-mode.html is failing

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r217828%20(2009)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ffullscreen-api-enabled-media-with-presentation-mode.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/fullscreen-api-enabled-media-with-presentation-mode-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/fullscreen-api-enabled-media-with-presentation-mode-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 5076: TypeError: controls.hidePlacard is not a function. (In 'controls.hidePlacard()', 'controls.hidePlacard' is undefined)
 Tests that the video's presentation mode is updated accordingly after entering and exiting Full Screen
 
 EXPECTED (video.webkitPresentationMode == 'inline') OK
Comment 1 Ryan Haddad 2017-06-06 09:52:58 PDT
<rdar://problem/31898037>
Comment 2 Ryan Haddad 2017-06-06 12:53:30 PDT
Marked test as failing in http://trac.webkit.org/projects/webkit/changeset/217850
Comment 3 Karl Rackler 2020-06-29 13:19:55 PDT
media/fullscreen-api-enabled-media-with-presentation-mode.html is no longer failing - remove expectations

Current history is green: https://results.webkit.org/?suite=layout-tests&test=media%2Ffullscreen-api-enabled-media-with-presentation-mode.html
Comment 4 Karl Rackler 2020-06-29 13:24:54 PDT
Created attachment 403104 [details]
Patch
Comment 5 Karl Rackler 2020-06-29 14:05:54 PDT
Created attachment 403110 [details]
Patch
Comment 6 EWS 2020-06-29 14:42:13 PDT
Committed r263697: <https://trac.webkit.org/changeset/263697>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403110 [details].