RESOLVED FIXED 172997
Cut down use of WTF_ARRAY_LENGTH 
https://bugs.webkit.org/show_bug.cgi?id=172997
Summary Cut down use of WTF_ARRAY_LENGTH
Darin Adler
Reported 2017-06-06 09:45:41 PDT
Cut down usese of WTF_ARRAY_LENGTH
Attachments
Patch (22.03 KB, patch)
2017-06-06 09:56 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (24.52 KB, patch)
2017-06-06 10:44 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (931.01 KB, application/zip)
2017-06-06 11:57 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.21 MB, application/zip)
2017-06-06 12:05 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-elcapitan (704.09 KB, application/zip)
2017-06-06 12:06 PDT, Build Bot 		no flags
Details
Patch (24.51 KB, patch)
2017-06-06 12:14 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (25.04 KB, patch)
2017-06-06 13:07 PDT, Darin Adler 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-06-06 09:56:20 PDT Comment hidden (obsolete)
Build Bot
Comment 2 2017-06-06 09:58:51 PDT Comment hidden (obsolete)
Darin Adler
Comment 3 2017-06-06 10:44:50 PDT Comment hidden (obsolete)
Build Bot
Comment 4 2017-06-06 11:32:41 PDT Comment hidden (obsolete)
Build Bot
Comment 5 2017-06-06 11:57:43 PDT Comment hidden (obsolete)
Build Bot
Comment 6 2017-06-06 11:57:44 PDT Comment hidden (obsolete)
Build Bot
Comment 7 2017-06-06 12:05:13 PDT Comment hidden (obsolete)
Build Bot
Comment 8 2017-06-06 12:05:15 PDT Comment hidden (obsolete)
Build Bot
Comment 9 2017-06-06 12:06:25 PDT Comment hidden (obsolete)
Build Bot
Comment 10 2017-06-06 12:06:27 PDT Comment hidden (obsolete)
Darin Adler
Comment 11 2017-06-06 12:14:44 PDT Comment hidden (obsolete)
Darin Adler
Comment 12 2017-06-06 12:15:33 PDT
Oops, forgot the "-1" for the null character terminator in the strings. Fixed now.
Build Bot
Comment 13 2017-06-06 12:58:30 PDT Comment hidden (obsolete)
Darin Adler
Comment 14 2017-06-06 13:07:31 PDT
Created attachment 312111 [details] Patch
Darin Adler
Comment 15 2017-06-06 14:09:52 PDT
Passes all the tests now so ready for review.
Chris Dumez
Comment 16 2017-06-06 14:57:43 PDT
Comment on attachment 312111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312111&action=review r=me > Source/WTF/ChangeLog:12 > + equalLettersIgnoringASCIICase insetad of strncasecmp. Typo: instead > Source/WebCore/platform/graphics/FontCascade.cpp:540 > + return !fontFamiliesWithInvalidCharWidthMap.get().contains(family); Personally preferred the old ->
Darin Adler
Comment 17 2017-06-06 15:04:05 PDT
Comment on attachment 312111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312111&action=review >> Source/WebCore/platform/graphics/FontCascade.cpp:540 >> + return !fontFamiliesWithInvalidCharWidthMap.get().contains(family); > > Personally preferred the old -> The -> before was dereferencing a pointer. The new code is dealing with NeverDestroyed and I don’t think it has operator-> support, although for some reason LazyNeverDestroyed does.
Chris Dumez
Comment 18 2017-06-06 15:05:32 PDT
Comment on attachment 312111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312111&action=review >>> Source/WebCore/platform/graphics/FontCascade.cpp:540 >>> + return !fontFamiliesWithInvalidCharWidthMap.get().contains(family); >> >> Personally preferred the old -> > > The -> before was dereferencing a pointer. The new code is dealing with NeverDestroyed and I don’t think it has operator-> support, although for some reason LazyNeverDestroyed does. My bad, I misread. Odd that LazyNeverDestroyed has an operator-> but not NeverDestroyed.
Darin Adler
Comment 19 2017-06-06 15:09:48 PDT
Committed r217860: <http://trac.webkit.org/changeset/217860>
Note You need to log in before you can comment on or make changes to this bug.