Bug 172981 - Add an option to disable getUserMedia prompt in case of mock capture sources
Summary: Add an option to disable getUserMedia prompt in case of mock capture sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-06 08:25 PDT by youenn fablet
Modified: 2017-06-06 09:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.72 KB, patch)
2017-06-06 08:39 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (11.81 KB, patch)
2017-06-06 09:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-06-06 08:25:30 PDT 
This is useful for web site continuous integration testing
Comment 1 youenn fablet 2017-06-06 08:26:15 PDT 
<rdar://problem/32580325>
Comment 2 Radar WebKit Bug Importer 2017-06-06 08:26:38 PDT 
<rdar://problem/32589319>
Comment 3 youenn fablet 2017-06-06 08:39:50 PDT 
Created attachment 312075 [details]
Patch
Comment 4 Eric Carlson 2017-06-06 08:46:26 PDT 
Comment on attachment 312075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312075&action=review

> Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:214
> +            // FIXME: We should probably only allow this if page is already actively capturing or page is visible.
> +            // If page is hidden and not capturing, we should wait for page to be visible before allowing the request.

This should have a bug number.
Comment 5 youenn fablet 2017-06-06 09:04:10 PDT 
Created attachment 312076 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-06-06 09:53:58 PDT 
Comment on attachment 312076 [details]
Patch for landing

Clearing flags on attachment: 312076

Committed r217837: <http://trac.webkit.org/changeset/217837>
Comment 7 WebKit Commit Bot 2017-06-06 09:54:00 PDT 
All reviewed patches have been landed.  Closing bug.