[WebIDL] PutForwards is not implemented to spec as illustrated by the WPT WebIDL/ecmascript-binding/put-forwards.html
Created attachment 312050 [details] Patch
Created attachment 312051 [details] Patch
Created attachment 312052 [details] Patch
Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3879564 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html
Created attachment 312054 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3879563 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html
Created attachment 312055 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3879530 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html
Created attachment 312056 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3879582 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html
Created attachment 312057 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 312128 [details] Patch
Comment on attachment 312128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312128&action=review r=me > Source/WebCore/ChangeLog:7 > + Link to the spec? > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4601 > + # FIXME: What should the second value to the PutPropertySlot be? We should probably file a bug against the WebIDL spec about the missing "Throw" argument to ES's Set(): Perform ? Set(Q, forwardId, V). I am assuming false is the right thing to do though. > LayoutTests/imported/w3c/ChangeLog:10 > +2017-06-05 Sam Weinig <sam@webkit.org> Double changelog.
(In reply to Chris Dumez from comment #13) > Comment on attachment 312128 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312128&action=review > > r=me > > > Source/WebCore/ChangeLog:7 > > + > > Link to the spec? > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4601 > > + # FIXME: What should the second value to the PutPropertySlot be? > > We should probably file a bug against the WebIDL spec about the missing https://github.com/heycam/webidl/issues/368 > "Throw" argument to ES's Set(): > Perform ? Set(Q, forwardId, V). > > I am assuming false is the right thing to do though. It might be based on strict mode or not. I'm not really sure. > > > LayoutTests/imported/w3c/ChangeLog:10 > > +2017-06-05 Sam Weinig <sam@webkit.org> > > Double changelog. :( I should make the style checker catch this, but I hate the style checker.
Committed r217895: <http://trac.webkit.org/changeset/217895>