Bug 172949 - Safari doesn't load newest The Order of the Stick comic.
Summary: Safari doesn't load newest The Order of the Stick comic.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
: 169742 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-05 19:49 PDT by zalan
Modified: 2018-05-03 07:13 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.38 KB, patch)
2017-06-05 20:23 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2017-06-05 20:24 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (4.69 KB, patch)
2017-06-06 11:57 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-06-05 19:49:44 PDT
1. Go to http://www.giantitp.com/Comics.html
2. Click the "New" link for The Order of the Stick
Comment 1 zalan 2017-06-05 19:49:58 PDT
rdar://problem/32389730
Comment 2 zalan 2017-06-05 20:23:53 PDT
Created attachment 312046 [details]
Patch
Comment 3 zalan 2017-06-05 20:24:43 PDT
Created attachment 312047 [details]
Patch
Comment 4 Sam Weinig 2017-06-05 20:37:57 PDT
Comment on attachment 312047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312047&action=review

> Source/WebCore/ChangeLog:16
> +        Need to add a testcase.

Agreed :).
Comment 5 Simon Fraser (smfr) 2017-06-05 22:19:53 PDT
Comment on attachment 312047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312047&action=review

> Source/WebCore/ChangeLog:11
> +        chain dirty, this dirty flag on the RenderTableRows will never be cleared and we'll end up early returning from RenderTableRow::paint.

RenderTableRow::paint() doesn't early return on needsLayout does it? I don't see that in the code.
Comment 6 zalan 2017-06-05 22:32:28 PDT
(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 312047 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312047&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        chain dirty, this dirty flag on the RenderTableRows will never be cleared and we'll end up early returning from RenderTableRow::paint.
> 
> RenderTableRow::paint() doesn't early return on needsLayout does it? I don't
> see that in the code.
Right, my mistake. It's the RenderTableSection::paint.
Comment 7 Simon Fraser (smfr) 2017-06-05 22:35:34 PDT
Weird that RenderTableSection has an early return that prevents painting. I guess we were just working around other table dirty layout bugs. We should remove that, or just paint a diagnostic color or something.
Comment 8 zalan 2017-06-05 22:38:43 PDT
(In reply to Simon Fraser (smfr) from comment #7)
> Weird that RenderTableSection has an early return that prevents painting. I
> guess we were just working around other table dirty layout bugs. We should
> remove that, or just paint a diagnostic color or something.
Agree. I don't mind removing it in a separate patch.
Comment 9 Antti Koivisto 2017-06-06 08:26:15 PDT
Comment on attachment 312047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312047&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3698
> +        if (needsLayout())
> +            return;
> +        // FIXME: We should just kick off a subtree layout here (if needed at all) see webkit.org/b/172947.
> +        setNeedsLayout();

Maybe we can just remove this at some point.
Comment 10 zalan 2017-06-06 11:57:44 PDT
Created attachment 312098 [details]
Patch
Comment 11 WebKit Commit Bot 2017-06-06 12:36:00 PDT
Comment on attachment 312098 [details]
Patch

Clearing flags on attachment: 312098

Committed r217848: <http://trac.webkit.org/changeset/217848>
Comment 12 WebKit Commit Bot 2017-06-06 12:36:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Simon Fraser (smfr) 2017-06-06 13:26:29 PDT
Comment on attachment 312098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312098&action=review

> LayoutTests/fast/table/floating-table-sibling-is-invisible.html:13
> +	font-size: 10px;

There is a tab here.
Comment 14 Andres Gomez Garcia 2018-05-03 07:13:19 PDT
*** Bug 169742 has been marked as a duplicate of this bug. ***