Bug 172942 – Update JSC's features.json

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

landed in:
https://trac.webkit.org/changeset/217805/webkit

[Saam Barati]

Rubber stamped by Mark Lam in person.

[Saam Barati]

*** Bug 172865 has been marked as a duplicate of this bug. ***

[David Kilzer (:ddkilzer)]

The <https://webkit.org/status/> page may have broken after this change.  Tried to fix it with:

<https://trac.webkit.org/r217816>

However, that didn't seem to change anything.

[David Kilzer (:ddkilzer)]

So I think the problem is that "ESNext" was used as a specification in a feature, but it wasn't listed in the "specification" section at the top of features.json.

Should we change "ESNext" to "ES7", or add an entry for "ESNext"?

    {
        "name": "ES7",
        "url": "https://github.com/tc39/ecma262",
        "keywords": ["es7", "ecmascript"]
    },
    {
        "name": "ESNext",
        "url": "https://tc39.github.io/ecma262/",
        "keywords": ["esnext", "ecmascript"]
    },

[Saam Barati]

(In reply to David Kilzer (:ddkilzer) from comment #5)
> So I think the problem is that "ESNext" was used as a specification in a
> feature, but it wasn't listed in the "specification" section at the top of
> features.json.
> 
> Should we change "ESNext" to "ES7", or add an entry for "ESNext"?
> 
>     {
>         "name": "ES7",
>         "url": "https://github.com/tc39/ecma262",
>         "keywords": ["es7", "ecmascript"]
>     },
>     {
>         "name": "ESNext",
>         "url": "https://tc39.github.io/ecma262/",
>         "keywords": ["esnext", "ecmascript"]
>     },

I'll update with a new ESNext section.

[Saam Barati]

(In reply to Saam Barati from comment #6)
> (In reply to David Kilzer (:ddkilzer) from comment #5)
> > So I think the problem is that "ESNext" was used as a specification in a
> > feature, but it wasn't listed in the "specification" section at the top of
> > features.json.
> > 
> > Should we change "ESNext" to "ES7", or add an entry for "ESNext"?
> > 
> >     {
> >         "name": "ES7",
> >         "url": "https://github.com/tc39/ecma262",
> >         "keywords": ["es7", "ecmascript"]
> >     },
> >     {
> >         "name": "ESNext",
> >         "url": "https://tc39.github.io/ecma262/",
> >         "keywords": ["esnext", "ecmascript"]
> >     },
> 
> I'll update with a new ESNext section.

About to land now.

[Saam Barati]

landed follow up ESNext section in:
https://trac.webkit.org/changeset/217819/webkit

Thanks for looking into this Dave.

[Saam Barati]

https://webkit.org/status/ appears to work.

[Simon Fraser (smfr)]

I filed bug 172958 to do more json validation.