Bug 172942 - Update JSC's features.json
Summary: Update JSC's features.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
: 172865 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-05 16:25 PDT by Saam Barati
Modified: 2017-06-06 09:42 PDT (History)
13 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-06-05 16:25:56 PDT
...
Comment 1 Saam Barati 2017-06-05 16:32:48 PDT
landed in:
https://trac.webkit.org/changeset/217805/webkit
Comment 2 Saam Barati 2017-06-05 16:32:59 PDT
Rubber stamped by Mark Lam in person.
Comment 3 Saam Barati 2017-06-05 17:19:08 PDT
*** Bug 172865 has been marked as a duplicate of this bug. ***
Comment 4 David Kilzer (:ddkilzer) 2017-06-05 20:55:13 PDT
The <https://webkit.org/status/> page may have broken after this change.  Tried to fix it with:

<https://trac.webkit.org/r217816>

However, that didn't seem to change anything.
Comment 5 David Kilzer (:ddkilzer) 2017-06-05 21:27:56 PDT
So I think the problem is that "ESNext" was used as a specification in a feature, but it wasn't listed in the "specification" section at the top of features.json.

Should we change "ESNext" to "ES7", or add an entry for "ESNext"?

    {
        "name": "ES7",
        "url": "https://github.com/tc39/ecma262",
        "keywords": ["es7", "ecmascript"]
    },
    {
        "name": "ESNext",
        "url": "https://tc39.github.io/ecma262/",
        "keywords": ["esnext", "ecmascript"]
    },
Comment 6 Saam Barati 2017-06-05 21:51:43 PDT
(In reply to David Kilzer (:ddkilzer) from comment #5)
> So I think the problem is that "ESNext" was used as a specification in a
> feature, but it wasn't listed in the "specification" section at the top of
> features.json.
> 
> Should we change "ESNext" to "ES7", or add an entry for "ESNext"?
> 
>     {
>         "name": "ES7",
>         "url": "https://github.com/tc39/ecma262",
>         "keywords": ["es7", "ecmascript"]
>     },
>     {
>         "name": "ESNext",
>         "url": "https://tc39.github.io/ecma262/",
>         "keywords": ["esnext", "ecmascript"]
>     },

I'll update with a new ESNext section.
Comment 7 Saam Barati 2017-06-05 21:51:53 PDT
(In reply to Saam Barati from comment #6)
> (In reply to David Kilzer (:ddkilzer) from comment #5)
> > So I think the problem is that "ESNext" was used as a specification in a
> > feature, but it wasn't listed in the "specification" section at the top of
> > features.json.
> > 
> > Should we change "ESNext" to "ES7", or add an entry for "ESNext"?
> > 
> >     {
> >         "name": "ES7",
> >         "url": "https://github.com/tc39/ecma262",
> >         "keywords": ["es7", "ecmascript"]
> >     },
> >     {
> >         "name": "ESNext",
> >         "url": "https://tc39.github.io/ecma262/",
> >         "keywords": ["esnext", "ecmascript"]
> >     },
> 
> I'll update with a new ESNext section.

About to land now.
Comment 8 Saam Barati 2017-06-05 21:54:07 PDT
landed follow up ESNext section in:
https://trac.webkit.org/changeset/217819/webkit

Thanks for looking into this Dave.
Comment 9 Saam Barati 2017-06-05 21:54:49 PDT
https://webkit.org/status/ appears to work.
Comment 10 Simon Fraser (smfr) 2017-06-05 22:01:40 PDT
I filed bug 172958 to do more json validation.