Bug 172932 - Update media controls to match latest design specs
Summary: Update media controls to match latest design specs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-05 13:36 PDT by Antoine Quint
Modified: 2018-01-10 23:43 PST (History)
5 users (show)

See Also:


Attachments
Patch (388.87 KB, patch)
2017-06-05 13:45 PDT, Antoine Quint
dino: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (925.81 KB, application/zip)
2017-06-05 15:17 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-06-05 13:36:31 PDT
The latest iOS and macOS releases have an updated look for media controls, and we need to implement it.
Comment 1 Radar WebKit Bug Importer 2017-06-05 13:36:44 PDT
<rdar://problem/32571531>
Comment 2 Antoine Quint 2017-06-05 13:45:43 PDT
Created attachment 312028 [details]
Patch
Comment 3 Dean Jackson 2017-06-05 13:49:19 PDT
Comment on attachment 312028 [details]
Patch

rs=me
Comment 4 Build Bot 2017-06-05 15:17:02 PDT
Comment on attachment 312028 [details]
Patch

Attachment 312028 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3877856

New failing tests:
media/track/track-cue-overlap-snap-to-lines-not-set.html
Comment 5 Build Bot 2017-06-05 15:17:03 PDT
Created attachment 312034 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 6 Antoine Quint 2017-06-06 01:10:49 PDT
Committed r217823: <http://trac.webkit.org/changeset/217823>
Comment 7 Scott Steele 2018-01-09 13:53:22 PST
I have custom controls in my application which allow drag/drop of videos to stimulate program change, size change, etc.  The resolution of this bug captures and cancels all dragenter events in the media-controls-container which overlays the entire video, thereby breaking my custom controls.  Since this happens in a closed shadowDOM with no styling access via a pseudo class or reference to the event handler, I see no workaround that will allow me to drag and drop videos in my application.  Is there another approach that would preserve the application's ability to drag the video element?
Comment 8 Antoine Quint 2018-01-10 23:43:04 PST
(In reply to Scott Steele from comment #7)
> I have custom controls in my application which allow drag/drop of videos to
> stimulate program change, size change, etc.  The resolution of this bug
> captures and cancels all dragenter events in the media-controls-container
> which overlays the entire video, thereby breaking my custom controls.  Since
> this happens in a closed shadowDOM with no styling access via a pseudo class
> or reference to the event handler, I see no workaround that will allow me to
> drag and drop videos in my application.  Is there another approach that
> would preserve the application's ability to drag the video element?

Thanks for the feedback Scott. Could you raise a separate bug about this? We need to track that as an individual issue and fix it so that we only prevent drag when the `controls` attribute is present on the media element.