NEW 172929
webkitpy: Extract ScriptError to its own file 
https://bugs.webkit.org/show_bug.cgi?id=172929
Summary webkitpy: Extract ScriptError to its own file
Daniel Bates
Reported 2017-06-05 11:44:26 PDT
We should move ScriptError to its own file as it is useful on its own.
Attachments
Patch (53.67 KB, patch)
2017-06-05 11:48 PDT, Daniel Bates 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-05 11:44:59 PDT
<rdar://problem/32569747>
Daniel Bates
Comment 2 2017-06-05 11:48:35 PDT
Created attachment 312021 [details] Patch
Build Bot
Comment 3 2017-06-05 11:50:36 PDT
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`) This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Ryosuke Niwa
Comment 4 2017-06-08 13:27:16 PDT
Comment on attachment 312021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312021&action=review Please fix the copyright. > Tools/Scripts/webkitpy/common/system/scripterror.py:1 > +# Copyright (C) 2017 Apple Inc. All rights reserved. Clearly, the content of this file is copyrighted by Google in 2009, 2010, 2011 and 2013. e.g. https://trac.webkit.org/browser/webkit/trunk/WebKitTools/Scripts/modules/executive.py?rev=51891 https://trac.webkit.org/changeset/53777/webkit/trunk/WebKitTools/Scripts/webkitpy/executive.py https://trac.webkit.org/changeset/75586/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py https://trac.webkit.org/changeset/143910/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py https://trac.webkit.org/changeset/202362/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py I recommend looking through the blame. Also, since we're not adding any content in 2017, it's probably misnomer to claim copyright this year even though we're moving the content.
Daniel Bates
Comment 5 2017-06-08 15:17:53 PDT
(In reply to Ryosuke Niwa from comment #4) > Comment on attachment 312021 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312021&action=review > > Please fix the copyright. > > > Tools/Scripts/webkitpy/common/system/scripterror.py:1 > > +# Copyright (C) 2017 Apple Inc. All rights reserved. > > Clearly, the content of this file is copyrighted by Google in 2009, 2010, > 2011 and 2013. > e.g. > https://trac.webkit.org/browser/webkit/trunk/WebKitTools/Scripts/modules/ > executive.py?rev=51891 > https://trac.webkit.org/changeset/53777/webkit/trunk/WebKitTools/Scripts/ > webkitpy/executive.py > https://trac.webkit.org/changeset/75586/webkit/trunk/Tools/Scripts/webkitpy/ > common/system/executive.py > https://trac.webkit.org/changeset/143910/webkit/trunk/Tools/Scripts/webkitpy/ > common/system/executive.py > https://trac.webkit.org/changeset/202362/webkit/trunk/Tools/Scripts/webkitpy/ > common/system/executive.py > > I recommend looking through the blame. Also, since we're not adding any > content in 2017, > it's probably misnomer to claim copyright this year even though we're moving > the content. Will fix copyright before landing.
Note You need to log in before you can comment on or make changes to this bug.