Bug 172929 - webkitpy: Extract ScriptError to its own file
Summary: webkitpy: Extract ScriptError to its own file
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-05 11:44 PDT by Daniel Bates
Modified: 2017-06-08 15:17 PDT (History)
9 users (show)

See Also:


Attachments
Patch (53.67 KB, patch)
2017-06-05 11:48 PDT, Daniel Bates
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-06-05 11:44:26 PDT
We should move ScriptError to its own file as it is useful on its own.
Comment 1 Radar WebKit Bug Importer 2017-06-05 11:44:59 PDT
<rdar://problem/32569747>
Comment 2 Daniel Bates 2017-06-05 11:48:35 PDT
Created attachment 312021 [details]
Patch
Comment 3 Build Bot 2017-06-05 11:50:36 PDT
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Ryosuke Niwa 2017-06-08 13:27:16 PDT
Comment on attachment 312021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312021&action=review

Please fix the copyright.

> Tools/Scripts/webkitpy/common/system/scripterror.py:1
> +# Copyright (C) 2017 Apple Inc. All rights reserved.

Clearly, the content of this file is copyrighted by Google in 2009, 2010, 2011 and 2013.
e.g. https://trac.webkit.org/browser/webkit/trunk/WebKitTools/Scripts/modules/executive.py?rev=51891
https://trac.webkit.org/changeset/53777/webkit/trunk/WebKitTools/Scripts/webkitpy/executive.py
https://trac.webkit.org/changeset/75586/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py
https://trac.webkit.org/changeset/143910/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py
https://trac.webkit.org/changeset/202362/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py

I recommend looking through the blame. Also, since we're not adding any content in 2017,
it's probably misnomer to claim copyright this year even though we're moving the content.
Comment 5 Daniel Bates 2017-06-08 15:17:53 PDT
(In reply to Ryosuke Niwa from comment #4)
> Comment on attachment 312021 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312021&action=review
> 
> Please fix the copyright.
> 
> > Tools/Scripts/webkitpy/common/system/scripterror.py:1
> > +# Copyright (C) 2017 Apple Inc. All rights reserved.
> 
> Clearly, the content of this file is copyrighted by Google in 2009, 2010,
> 2011 and 2013.
> e.g.
> https://trac.webkit.org/browser/webkit/trunk/WebKitTools/Scripts/modules/
> executive.py?rev=51891
> https://trac.webkit.org/changeset/53777/webkit/trunk/WebKitTools/Scripts/
> webkitpy/executive.py
> https://trac.webkit.org/changeset/75586/webkit/trunk/Tools/Scripts/webkitpy/
> common/system/executive.py
> https://trac.webkit.org/changeset/143910/webkit/trunk/Tools/Scripts/webkitpy/
> common/system/executive.py
> https://trac.webkit.org/changeset/202362/webkit/trunk/Tools/Scripts/webkitpy/
> common/system/executive.py
> 
> I recommend looking through the blame. Also, since we're not adding any
> content in 2017,
> it's probably misnomer to claim copyright this year even though we're moving
> the content.

Will fix copyright before landing.