Bug 172923 - [GStreamer] Use the same draw timer and mutex when AC disabled or building without OpenGL
Summary: [GStreamer] Use the same draw timer and mutex when AC disabled or building wi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2017-06-05 09:32 PDT by Carlos Garcia Campos
Modified: 2017-06-06 02:01 PDT (History)
3 users (show)

See Also:

Patch (7.94 KB, patch)
2017-06-05 09:35 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-05 09:32:30 PDT
We have two different paths to do the same, when building without OpenGL, the VideoRenderRequestScheduler has its own timer and we need to add ifdefs to handle that. But when building with OpenGL we still support non-accelerated rendering that does the same than the VideoRenderRequestScheduler timer, but using the media player timer instead. We can simplify the code and remove more ifdefs by using the media player timer and mutex in all cases for non-accelerated rendering.
Comment 1 Carlos Garcia Campos 2017-06-05 09:35:22 PDT
Created attachment 312012 [details]
Comment 2 Michael Catanzaro 2017-06-05 14:23:04 PDT
Comment on attachment 312012 [details]

Nice! r=me, conditional on Miguel's approval.
Comment 3 Miguel Gomez 2017-06-06 01:32:06 PDT
Looks good and usual use cases work :)
Comment 4 Carlos Garcia Campos 2017-06-06 01:38:44 PDT
I built without OpenGL yesterday to try it out.
Comment 5 Carlos Garcia Campos 2017-06-06 02:01:24 PDT
Committed r217824: <http://trac.webkit.org/changeset/217824>