Bug 172921 - [WPE][JHBuild] Switch github repository from git:// to https://
Summary: [WPE][JHBuild] Switch github repository from git:// to https://
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-05 09:08 PDT by Carlos Alberto Lopez Perez
Modified: 2017-06-05 19:04 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2017-06-05 09:13 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-06-05 09:08:31 PDT
On bug 148941 some developers reported having trouble to fetch resources of the WebKitGTK+ JHBuild not served via http or https due to restrictive firewalls they had to suffer.

So, let's try to do this also for the WPE port.
Comment 1 Michael Catanzaro 2017-06-05 09:12:16 PDT
This is good to do anyway, independent of problematic firewalls.
Comment 2 Carlos Alberto Lopez Perez 2017-06-05 09:13:40 PDT
Created attachment 312011 [details]
Patch
Comment 3 Alex Christensen 2017-06-05 13:08:59 PDT
Comment on attachment 312011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312011&action=review

> Tools/wpe/jhbuild.modules:30
> +  <!-- Please use http/https to access repositories to be friendly to users stuck behind firewalls. -->

Should we only allow https?
Comment 4 Carlos Alberto Lopez Perez 2017-06-05 13:19:35 PDT
(In reply to Alex Christensen from comment #3)
> Comment on attachment 312011 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312011&action=review
> 
> > Tools/wpe/jhbuild.modules:30
> > +  <!-- Please use http/https to access repositories to be friendly to users stuck behind firewalls. -->
> 
> Should we only allow https?

Thanks!

I think is a good idea defaulting to https, but some sites may still only be accessible via http.

In any case JHBuild always checks the hash or the source tarball after downloading it.
Comment 5 WebKit Commit Bot 2017-06-05 13:54:11 PDT
Comment on attachment 312011 [details]
Patch

Clearing flags on attachment: 312011

Committed r217792: <http://trac.webkit.org/changeset/217792>
Comment 6 WebKit Commit Bot 2017-06-05 13:54:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Michael Catanzaro 2017-06-05 14:24:17 PDT
(In reply to Carlos Alberto Lopez Perez from comment #4)
> In any case JHBuild always checks the hash or the source tarball after
> downloading it.

Well it's certainly supposed to... though if I remember correctly, when I tested this once before it didn't work.
Comment 8 Carlos Alberto Lopez Perez 2017-06-05 16:28:45 PDT
(In reply to Michael Catanzaro from comment #7)
> (In reply to Carlos Alberto Lopez Perez from comment #4)
> > In any case JHBuild always checks the hash or the source tarball after
> > downloading it.
> 
> Well it's certainly supposed to... though if I remember correctly, when I
> tested this once before it didn't work.

Really?
I tested this several times and it always worked as expected for me.
Comment 9 Michael Catanzaro 2017-06-05 19:04:05 PDT
Well, that's good then.