Bug 172921 – [WPE][JHBuild] Switch github repository from git:// to https://

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

On bug 148941 some developers reported having trouble to fetch resources of the WebKitGTK+ JHBuild not served via http or https due to restrictive firewalls they had to suffer.

So, let's try to do this also for the WPE port.

[Michael Catanzaro]

This is good to do anyway, independent of problematic firewalls.

[Carlos Alberto Lopez Perez]

Created attachment 312011 [details]
Patch

[Alex Christensen]

Comment on attachment 312011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312011&action=review

> Tools/wpe/jhbuild.modules:30
> +  <!-- Please use http/https to access repositories to be friendly to users stuck behind firewalls. -->

Should we only allow https?

[Carlos Alberto Lopez Perez]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 312011 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312011&action=review
> 
> > Tools/wpe/jhbuild.modules:30
> > +  <!-- Please use http/https to access repositories to be friendly to users stuck behind firewalls. -->
> 
> Should we only allow https?

Thanks!

I think is a good idea defaulting to https, but some sites may still only be accessible via http.

In any case JHBuild always checks the hash or the source tarball after downloading it.

[WebKit Commit Bot]

Comment on attachment 312011 [details]
Patch

Clearing flags on attachment: 312011

Committed r217792: <http://trac.webkit.org/changeset/217792>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

(In reply to Carlos Alberto Lopez Perez from comment #4)
> In any case JHBuild always checks the hash or the source tarball after
> downloading it.

Well it's certainly supposed to... though if I remember correctly, when I tested this once before it didn't work.

[Carlos Alberto Lopez Perez]

(In reply to Michael Catanzaro from comment #7)
> (In reply to Carlos Alberto Lopez Perez from comment #4)
> > In any case JHBuild always checks the hash or the source tarball after
> > downloading it.
> 
> Well it's certainly supposed to... though if I remember correctly, when I
> tested this once before it didn't work.

Really?
I tested this several times and it always worked as expected for me.

[Michael Catanzaro]

Well, that's good then.