Bug 172918 - [GStreamer] Cleanup ifdefs in MediaPlayerPrivateGStreamerBase
Summary: [GStreamer] Cleanup ifdefs in MediaPlayerPrivateGStreamerBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 170003
  Show dependency tree / graph
 
Reported: 2017-06-05 06:04 PDT by Carlos Garcia Campos
Modified: 2017-06-05 09:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (17.08 KB, patch)
2017-06-05 06:30 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-05 06:04:20 PDT 
The code in MediaPlayerPrivateGStreamerBase is quite difficult to follow with all the ifdefs for the possibilities when rendering. Some of them are even dead code now that all ports using GStreamer are using also coordinated graphics.
Comment 1 Carlos Garcia Campos 2017-06-05 06:30:38 PDT 
Created attachment 312008 [details]
Patch
Comment 2 Miguel Gomez 2017-06-05 08:29:29 PDT 
(In reply to Carlos Garcia Campos from comment #1)
> Created attachment 312008 [details]
> Patch

Looks good to me, and video use cases seem to be working properly.

At last getting rid of that code!! \o/
Comment 3 Michael Catanzaro 2017-06-05 09:20:55 PDT 
Comment on attachment 312008 [details]
Patch

It's still a mess, but I see it's better than before. rs=me based on Miguel's review.
Comment 4 Michael Catanzaro 2017-06-05 09:21:40 PDT 
Also, Calvaris, if you want to review these GStreamer patches, let me know and I'll leave r+ for you... I'm just assuming you're busy.
Comment 5 Carlos Garcia Campos 2017-06-05 09:26:06 PDT 
Committed r217785: <http://trac.webkit.org/changeset/217785>