Bug 172901 – Percentages are calculated wrong in SVG transform CSS property

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

Created attachment 311955 [details]
CSS Transform Test Case

The transform CSS property calculates percentages wrong in SVG. They should be relative to the parent viewport, but they seem to be relative to the element’s size. This can be seen by changing the blue rectangle’s width in the test case.

In the test case, the blue rectangles should be close to the middle line. The blue one on the right side of the line, the aqua colored at the center. The rectangles should follow the line if the browser window is resized.

Firefox can display the test case correctly.

Chrome has a similar bug: https://bugs.chromium.org/p/chromium/issues/detail?id=729386

[Simon Fraser (smfr)]

In a recent Safari Tech Preview, we now support transform-box and fix the behavior of percentages. However, this seems to be broken if the <svg> has no explicit viewBox.

[Simon Fraser (smfr)]

Created attachment 311981 [details]
Patch

Created attachment 311983 [details]
Symbol Test Case

Also <symbol> elements are affected. I've attached Symbol Test Case for it. I think your patch will fix them as well.

[Simon Fraser (smfr)]

Yeah, that testcase looks fine with the fix.

[WebKit Commit Bot]

Comment on attachment 311981 [details]
Patch

Clearing flags on attachment: 311981

Committed r217776: <http://trac.webkit.org/changeset/217776>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 311981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311981&action=review

> Source/WebCore/svg/SVGGraphicsElement.cpp:94
> +            FloatSize viewportSize;
> +            SVGLengthContext(this).determineViewport(viewportSize);
> +            boundingBox.setSize(viewportSize);

What if determineViewport returns false? I ask because I want to do a bit of refactoring to use std::optional and I am wondering whether this code is asserting that determineViewport always returns true or if it is taking advantage of the fact that size will be 0x0 if it returns false.

[Simon Fraser (smfr)]

(In reply to Darin Adler from comment #8)
> Comment on attachment 311981 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311981&action=review
> 
> > Source/WebCore/svg/SVGGraphicsElement.cpp:94
> > +            FloatSize viewportSize;
> > +            SVGLengthContext(this).determineViewport(viewportSize);
> > +            boundingBox.setSize(viewportSize);
> 
> What if determineViewport returns false? I ask because I want to do a bit of
> refactoring to use std::optional and I am wondering whether this code is
> asserting that determineViewport always returns true or if it is taking
> advantage of the fact that size will be 0x0 if it returns false.

The latter.