WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172889
Cleanup FrameView::autoSizeIfEnabled.
https://bugs.webkit.org/show_bug.cgi?id=172889
Summary
Cleanup FrameView::autoSizeIfEnabled.
zalan
Reported
2017-06-02 19:52:50 PDT
some minor cleanup.
Attachments
Patch
(7.08 KB, patch)
2017-06-02 19:58 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(7.13 KB, patch)
2017-06-02 20:14 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-06-02 19:53:29 PDT
<
rdar://problem/32550783
>
zalan
Comment 2
2017-06-02 19:58:11 PDT
Created
attachment 311899
[details]
Patch
Tim Horton
Comment 3
2017-06-02 20:00:20 PDT
Comment on
attachment 311899
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=311899&action=review
> Source/WebCore/ChangeLog:3 > + Clenaup FrameView::autoSizeIfEnabled.
Useless title, not even spelled right :)
> Source/WebCore/page/FrameView.cpp:3746 > + // FIXME: Now that autoSizeIfEnabled() actually returns clean, we don't need to call it from layout() anymore.
Don't know if this is a useful comment. Especially if not attached to a bug that explains why we might want to move it elsewhere.
zalan
Comment 4
2017-06-02 20:14:04 PDT
Created
attachment 311902
[details]
Patch
WebKit Commit Bot
Comment 5
2017-06-02 21:40:42 PDT
Comment on
attachment 311902
[details]
Patch Clearing flags on attachment: 311902 Committed
r217751
: <
http://trac.webkit.org/changeset/217751
>
WebKit Commit Bot
Comment 6
2017-06-02 21:40:44 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug