Bug 172887 – ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html

[Tim Horton]

Created attachment 311895 [details]
Patch

[Sam Weinig]

Comment on attachment 311895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311895&action=review

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:487
> +        // applyAutocorrection can call its completion handler synchronously,
> +        // which makes UIScriptController unhappy (see bug 172884).

Should we change applyAutocorrection? Are we consistent about whether completionHandlers can call back synchronously?

[Tim Horton]

(In reply to Sam Weinig from comment #2)
> Comment on attachment 311895 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311895&action=review
> 
> > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:487
> > +        // applyAutocorrection can call its completion handler synchronously,
> > +        // which makes UIScriptController unhappy (see bug 172884).
> 
> Should we change applyAutocorrection?

I don't think we can (it is the way it is for a reason: <rdar://problem/16207002>) yet.

> Are we consistent about whether
> completionHandlers can call back synchronously?

I think the API is fairly consistent, but this is not API, this is our implementation of an internal UIKit method.

[Tim Horton]

http://trac.webkit.org/changeset/217781/webkit