Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp
Created attachment 311896 [details] Patch
Created attachment 311906 [details] Patch
Comment on attachment 311906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311906&action=review > Source/WebCore/platform/graphics/FontCache.h:284 > +RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings* fontFaceFeatures, const FontVariantSettings* fontFaceVariantSettings, FontSelectionSpecifiedCapabilities fontFaceCapabilities, float size); Here this could be: RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings*, const FontVariantSettings*, FontSelectionSpecifiedCapabilities, float size);
Comment on attachment 311906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311906&action=review >> Source/WebCore/platform/graphics/FontCache.h:284 >> +RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings* fontFaceFeatures, const FontVariantSettings* fontFaceVariantSettings, FontSelectionSpecifiedCapabilities fontFaceCapabilities, float size); > > Here this could be: > > RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings*, const FontVariantSettings*, FontSelectionSpecifiedCapabilities, float size); I think, in this case, the argument names are helpful because the FontDescription also has members with these same types. The name describes how these values should be supplied from @font-face, rather than from the element's style itself.
Comment on attachment 311906 [details] Patch Clearing flags on attachment: 311906 Committed r217762: <http://trac.webkit.org/changeset/217762>
All reviewed patches have been landed. Closing bug.