Bug 172886 - Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp
Summary: Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 172893
  Show dependency treegraph
 
Reported: 2017-06-02 18:11 PDT by Myles C. Maxfield
Modified: 2017-06-03 11:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.60 KB, patch)
2017-06-02 18:14 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (10.76 KB, patch)
2017-06-02 22:38 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-06-02 18:11:29 PDT
Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp
Comment 1 Myles C. Maxfield 2017-06-02 18:14:27 PDT
Created attachment 311896 [details]
Patch
Comment 2 Myles C. Maxfield 2017-06-02 22:38:49 PDT
Created attachment 311906 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-06-03 10:12:20 PDT
Comment on attachment 311906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311906&action=review

> Source/WebCore/platform/graphics/FontCache.h:284
> +RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings* fontFaceFeatures, const FontVariantSettings* fontFaceVariantSettings, FontSelectionSpecifiedCapabilities fontFaceCapabilities, float size);

Here this could be:

RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings*, const FontVariantSettings*, FontSelectionSpecifiedCapabilities, float size);
Comment 4 Myles C. Maxfield 2017-06-03 10:37:36 PDT
Comment on attachment 311906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311906&action=review

>> Source/WebCore/platform/graphics/FontCache.h:284
>> +RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings* fontFaceFeatures, const FontVariantSettings* fontFaceVariantSettings, FontSelectionSpecifiedCapabilities fontFaceCapabilities, float size);
> 
> Here this could be:
> 
> RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings*, const FontVariantSettings*, FontSelectionSpecifiedCapabilities, float size);

I think, in this case, the argument names are helpful because the FontDescription also has members with these same types. The name describes how these values should be supplied from @font-face, rather than from the element's style itself.
Comment 5 WebKit Commit Bot 2017-06-03 11:07:20 PDT
Comment on attachment 311906 [details]
Patch

Clearing flags on attachment: 311906

Committed r217762: <http://trac.webkit.org/changeset/217762>
Comment 6 WebKit Commit Bot 2017-06-03 11:07:22 PDT
All reviewed patches have been landed.  Closing bug.