[GCrypt] Gather Web Crypto utility functions in a single header
Created attachment 311849 [details] Patch
Attachment 311849 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/gcrypt/GCryptUtilities.h:68: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 311849 [details] Patch Looks good to me. Michael, please double checks if there are any missing ones.
Comment on attachment 311849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311849&action=review Looks good to me as well... I just wonder why it wasn't written this way from the start! > Source/WebCore/crypto/gcrypt/GCryptUtilities.h:68 > + return std::nullopt;; One too many semicolons!
Comment on attachment 311849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311849&action=review >> Source/WebCore/crypto/gcrypt/GCryptUtilities.h:68 >> + return std::nullopt;; > > One too many semicolons! Oops...
Committed r217754: <http://trac.webkit.org/changeset/217754>