Bug 172861 – ResourceLoadStatistics are not using unique paths during test runs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

The ResourceLoadStatistics data store is not being set to a unique path when running tests, causing multiple processes to interact with the same file on disk. This is causing crashes in the test system.

[Chris Dumez]

<rdar://problem/32442251>

[Chris Dumez]

Created attachment 311863 [details]
Patch

[Brent Fulgham]

Comment on attachment 311863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311863&action=review

> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp:71
> +    configuration->m_resourceLoadStatisticsDirectory = legacyConfiguration.resourceLoadStatisticsDirectory;

Do we need this same change in ProcessPoolConfiguration::createWithLegacyOptions?

[Chris Dumez]

Comment on attachment 311863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311863&action=review

>> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp:71
>> +    configuration->m_resourceLoadStatisticsDirectory = legacyConfiguration.resourceLoadStatisticsDirectory;
> 
> Do we need this same change in ProcessPoolConfiguration::createWithLegacyOptions?

ProcessPoolConfiguration::createWithLegacyOptions() calls ProcessPoolConfiguration::create(), which will call the default constructor of ProcessPoolConfiguration which initializes m_resourceLoadStatisticsDirectory to WebsiteDataStore::defaultResourceLoadStatisticsDirectory() (in my patch). So it looks fine to me. Am I missing something? I don't think we have a legacy path for resource statistics so I assume using the default one is fine?

[WebKit Commit Bot]

Comment on attachment 311863 [details]
Patch

Clearing flags on attachment: 311863

Committed r217743: <http://trac.webkit.org/changeset/217743>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

Comment on attachment 311863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311863&action=review

>>> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp:71
>>> +    configuration->m_resourceLoadStatisticsDirectory = legacyConfiguration.resourceLoadStatisticsDirectory;
>> 
>> Do we need this same change in ProcessPoolConfiguration::createWithLegacyOptions?
> 
> ProcessPoolConfiguration::createWithLegacyOptions() calls ProcessPoolConfiguration::create(), which will call the default constructor of ProcessPoolConfiguration which initializes m_resourceLoadStatisticsDirectory to WebsiteDataStore::defaultResourceLoadStatisticsDirectory() (in my patch). So it looks fine to me. Am I missing something? I don't think we have a legacy path for resource statistics so I assume using the default one is fine?

You are right: we have no legacy data to worry about here.