Bug 172858 – [MediaStream iOS] Cleanup video muting/unmuting when tab visibility changes

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Don't unmute a video when a tab becomes visible unless it was muted when the tab was hidden.

[Eric Carlson]

Created attachment 311827 [details]
Proposed patch.

[Eric Carlson]

Comment on attachment 311827 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=311827&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:337
> +void RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility(bool muted)

shouldMute instead of muted?

> LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html:67
> +

Double space line

[Eric Carlson]

(In reply to Eric Carlson from comment #2)
> Comment on attachment 311827 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311827&action=review
> 
> > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:337
> > +void RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility(bool muted)
> 
> shouldMute instead of muted?
> 
> > LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html:67
> > +
> 
> Double space line

(Comments by Youenn on my machine)

[Eric Carlson]

Created attachment 311839 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 311839 [details]
Patch for landing.

Rejecting attachment 311839 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
bjects-normal/x86_64/FEComposite.dia -c /Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/filters/FEComposite.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/FEComposite.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/Document.o dom/Document.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/3860671

[Eric Carlson]

Created attachment 311855 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 311855 [details]
Patch for landing.

Clearing flags on attachment: 311855

Committed r217734: <http://trac.webkit.org/changeset/217734>

[Ahmad Saleem]

Seems landed and didn't back out.

https://github.com/WebKit/WebKit/commit/b47636fb155e81e898fc91fb11959757194bf78d

Marking this as "RESOLVED FIXED". Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/100828817>