Bug 172857 - [GCrypt] Fix PK verification for ECDSA
Summary: [GCrypt] Fix PK verification for ECDSA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 133122
  Show dependency treegraph
 
Reported: 2017-06-02 07:41 PDT by Zan Dobersek
Modified: 2017-06-03 03:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2017-06-02 07:43 PDT, Zan Dobersek
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-06-02 07:41:43 PDT
[GCrypt] Fix PK verification for ECDSA
Comment 1 Zan Dobersek 2017-06-02 07:43:47 PDT
Created attachment 311823 [details]
Patch
Comment 2 Michael Catanzaro 2017-06-02 09:09:16 PDT
Comment on attachment 311823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311823&action=review

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:226
> +    // a failure in any other case. OperationError should not be returned at this point.

The comment should explain *why* OperationError should not be returned at this point: to avoid spilling information about the exact cause of verification failure.
Comment 3 Zan Dobersek 2017-06-03 03:27:16 PDT
Committed r217753: <http://trac.webkit.org/changeset/217753>