Bug 172838 - Allow clients to override viewport size for CSS viewport units.
Summary: Allow clients to override viewport size for CSS viewport units.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-01 15:59 PDT by zalan
Modified: 2017-06-02 11:38 PDT (History)
6 users (show)

See Also:


Attachments
Patch (22.06 KB, patch)
2017-06-01 16:21 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (22.06 KB, patch)
2017-06-01 20:28 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-06-01 15:59:46 PDT
vh, vw etc
Comment 1 Radar WebKit Bug Importer 2017-06-01 16:00:52 PDT
<rdar://problem/32523441>
Comment 2 zalan 2017-06-01 16:21:35 PDT
Created attachment 311774 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-06-01 16:29:05 PDT
Comment on attachment 311774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311774&action=review

> Source/WebKit2/ChangeLog:11
> +        This enables auto-sizing clients to ensure that styles relative to the viewport are
> +        resolved to a set value (presumably the size of the container) as opposed to the preferred
> +        document size (which is set as the FrameView size).

How does this relate to fixedLayoutSize? Could we use that as something to resolve viewport units against?
Comment 4 Tim Horton 2017-06-01 16:54:29 PDT
Comment on attachment 311774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311774&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.h:883
> +    std::optional<WebCore::IntSize> viewportSizeForCSSViewportUnits() { return m_viewportSizeForCSSViewportUnits; }

const?
Comment 5 zalan 2017-06-01 20:28:48 PDT
Created attachment 311798 [details]
Patch
Comment 6 WebKit Commit Bot 2017-06-02 11:38:20 PDT
Comment on attachment 311798 [details]
Patch

Clearing flags on attachment: 311798

Committed r217725: <http://trac.webkit.org/changeset/217725>
Comment 7 WebKit Commit Bot 2017-06-02 11:38:22 PDT
All reviewed patches have been landed.  Closing bug.