RESOLVED FIXED 172838
Allow clients to override viewport size for CSS viewport units. 
https://bugs.webkit.org/show_bug.cgi?id=172838
Summary Allow clients to override viewport size for CSS viewport units.
zalan
Reported 2017-06-01 15:59:46 PDT
vh, vw etc
Attachments
Patch (22.06 KB, patch)
2017-06-01 16:21 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (22.06 KB, patch)
2017-06-01 20:28 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-01 16:00:52 PDT
<rdar://problem/32523441>
zalan
Comment 2 2017-06-01 16:21:35 PDT
Created attachment 311774 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-06-01 16:29:05 PDT
Comment on attachment 311774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311774&action=review > Source/WebKit2/ChangeLog:11 > + This enables auto-sizing clients to ensure that styles relative to the viewport are > + resolved to a set value (presumably the size of the container) as opposed to the preferred > + document size (which is set as the FrameView size). How does this relate to fixedLayoutSize? Could we use that as something to resolve viewport units against?
Tim Horton
Comment 4 2017-06-01 16:54:29 PDT
Comment on attachment 311774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311774&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.h:883 > + std::optional<WebCore::IntSize> viewportSizeForCSSViewportUnits() { return m_viewportSizeForCSSViewportUnits; } const?
zalan
Comment 5 2017-06-01 20:28:48 PDT
Created attachment 311798 [details] Patch
WebKit Commit Bot
Comment 6 2017-06-02 11:38:20 PDT
Comment on attachment 311798 [details] Patch Clearing flags on attachment: 311798 Committed r217725: <http://trac.webkit.org/changeset/217725>
WebKit Commit Bot
Comment 7 2017-06-02 11:38:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.