Bug 172804 – TestNetscapePlugIn: Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

WTF_ATTRIBUTE_PRINTF() only works outside the current
compilation unit if it's on the declaration, not the
implementation, of a function or class method.

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
---
 5 files changed, 19 insertions(+), 6 deletions(-)

[David Kilzer (:ddkilzer)]

Created attachment 311690 [details]
Patch

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 311690 [details]
> Patch

This may need the following fix as well:

+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wformat-nonliteral"
     pluginLogWithArguments(instance, format, args);
+#pragma clang diagnostic pop

Waiting for EWS.

[David Kilzer (:ddkilzer)]

Created attachment 311691 [details]
Patch v2

[David Kilzer (:ddkilzer)]

Created attachment 311714 [details]
Patch v3

[WebKit Commit Bot]

Comment on attachment 311714 [details]
Patch v3

Clearing flags on attachment: 311714

Committed r217847: <http://trac.webkit.org/changeset/217847>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.