Bug 172796 - Compilation errors from LocalizedStrings.cpp
Summary: Compilation errors from LocalizedStrings.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-31 20:51 PDT by Yoshiaki Jitsukawa
Modified: 2017-06-01 15:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.86 KB, patch)
2017-05-31 21:05 PDT, Yoshiaki Jitsukawa
achristensen: review-
Details | Formatted Diff | Diff
Patch (3.83 KB, patch)
2017-05-31 22:57 PDT, Yoshiaki Jitsukawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2017-05-31 20:51:45 PDT
https://trac.webkit.org/changeset/214244/webkit seems to have introduced compilation errors on such platforms other than USE(CF) || USE(GLIB).

There're some code like
 String::fromUTF8("Look Up “<selection>”", "Look Up context menu item with selected word")
but String::fromUTF8() cannot take two strings (for string and description).
Comment 1 Yoshiaki Jitsukawa 2017-05-31 21:05:31 PDT
Created attachment 311680 [details]
Patch
Comment 2 Yoshiaki Jitsukawa 2017-05-31 22:57:17 PDT
Created attachment 311684 [details]
Patch
Comment 3 Michael Catanzaro 2017-06-01 08:05:15 PDT
Would it be better/clearer to just remove the second argument instead, since WEB_UI_STRING degrades to String::fromUTF8 in this case anyway?
Comment 4 Don Olmstead 2017-06-01 10:45:11 PDT
(In reply to Michael Catanzaro from comment #3)
> Would it be better/clearer to just remove the second argument instead, since
> WEB_UI_STRING degrades to String::fromUTF8 in this case anyway?

The original patch just commented it out. I thought it would be more consistent with the rest of the file's contents to use WEB_UI_STRING.
Comment 5 WebKit Commit Bot 2017-06-01 15:32:27 PDT
Comment on attachment 311684 [details]
Patch

Clearing flags on attachment: 311684

Committed r217686: <http://trac.webkit.org/changeset/217686>
Comment 6 WebKit Commit Bot 2017-06-01 15:32:29 PDT
All reviewed patches have been landed.  Closing bug.