Bug 172789 - Remove overrides of visitChildren() that do not add any functionality.
Summary: Remove overrides of visitChildren() that do not add any functionality.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-31 17:21 PDT by Mark Lam
Modified: 2017-05-31 20:11 PDT (History)
10 users (show)

See Also:

Attachments
proposed patch. (16.83 KB, patch)
2017-05-31 17:27 PDT, Mark Lam 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (906.55 KB, application/zip)
2017-05-31 18:54 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-05-31 17:21:11 PDT 
Patch coming.
Comment 1 Radar WebKit Bug Importer 2017-05-31 17:23:37 PDT 
<rdar://problem/32500865>
Comment 2 Mark Lam 2017-05-31 17:27:22 PDT 
Created attachment 311663 [details]
proposed patch.
Comment 3 Andreas Kling 2017-05-31 17:59:41 PDT 
Comment on attachment 311663 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2017-05-31 18:53:05 PDT 
Thanks for the review.
Comment 5 Build Bot 2017-05-31 18:54:33 PDT 
Comment on attachment 311663 [details]
proposed patch.

Attachment 311663 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3851362

New failing tests:
webrtc/peer-connection-audio-mute.html
Comment 6 Build Bot 2017-05-31 18:54:35 PDT 
Created attachment 311672 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 7 Mark Lam 2017-05-31 20:06:28 PDT 
(In reply to Build Bot from comment #5)
> New failing tests:
> webrtc/peer-connection-audio-mute.html

This test has been failing intermittently on the ios-sim EWS for a long time now.  It's not due to my patch.
Comment 8 Mark Lam 2017-05-31 20:11:40 PDT 
Landed in r217645: <http://trac.webkit.org/r217645>.