Bug 172782 - CodeGeneratorJS's InstanceNeedsVisitChildren should not return true just because a class is / extends EventTarget.
Summary: CodeGeneratorJS's InstanceNeedsVisitChildren should not return true just beca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-31 15:49 PDT by Mark Lam
Modified: 2017-05-31 17:12 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (10.02 KB, patch)
2017-05-31 16:17 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-05-31 15:49:53 PDT 
The other conditions for generating visitChildren() are adequate if the class needs its own visitChildren.  Currently, we're generating some visitChildren() methods that only call its Base::visitChildren().  Removing the "is / extends EventTarget" conditions removes those unneeded visitChildren() overrides.
Comment 1 Radar WebKit Bug Importer 2017-05-31 15:56:04 PDT 
<rdar://problem/32498266>
Comment 2 Mark Lam 2017-05-31 16:07:37 PDT 
Ditto for the IsJSBuiltinConstructor condition, which is not used to emit any additional code in the visitChildren override.
Comment 3 Mark Lam 2017-05-31 16:17:22 PDT 
Created attachment 311651 [details]
proposed patch.

Let's test this on the EWS first.
Comment 4 Chris Dumez 2017-05-31 16:41:18 PDT 
Comment on attachment 311651 [details]
proposed patch.

r=me as long as bots are happy.
Comment 5 Mark Lam 2017-05-31 16:43:03 PDT 
Thanks for the review.
Comment 6 WebKit Commit Bot 2017-05-31 17:12:55 PDT 
Comment on attachment 311651 [details]
proposed patch.

Clearing flags on attachment: 311651

Committed r217642: <http://trac.webkit.org/changeset/217642>
Comment 7 WebKit Commit Bot 2017-05-31 17:12:56 PDT 
All reviewed patches have been landed.  Closing bug.