Bug 172771 – PeerConnection should respect tracks that are muted at the time they are added

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

Currently, it is not the case and muted state is not respected.

[youenn fablet]

Created attachment 311622 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/32493091>

[Eric Carlson]

Comment on attachment 311622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311622&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:105
> +    if (!m_muted && m_enabled && m_blackFrameTimer.isActive()) {
> +        m_blackFrameTimer.stop();
>          return;
>      }
> -    if (m_blackFrameTimer.isActive())
> -        m_blackFrameTimer.stop();
> +
> +    sendBlackFramesIfNeeded();

I would be nice to factor this into a function that can be shared with sourceMutedChanged.

[youenn fablet]

Created attachment 311625 [details]
Patch

[youenn fablet]

Thanks for the review.

(In reply to Eric Carlson from comment #3)
> Comment on attachment 311622 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311622&action=review
> 
> > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:105
> > +    if (!m_muted && m_enabled && m_blackFrameTimer.isActive()) {
> > +        m_blackFrameTimer.stop();
> >          return;
> >      }
> > -    if (m_blackFrameTimer.isActive())
> > -        m_blackFrameTimer.stop();
> > +
> > +    sendBlackFramesIfNeeded();
> 
> I would be nice to factor this into a function that can be shared with
> sourceMutedChanged.

Done.

[WebKit Commit Bot]

Comment on attachment 311625 [details]
Patch

Clearing flags on attachment: 311625

Committed r217624: <http://trac.webkit.org/changeset/217624>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.