Bug 172770 – [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Adrian Perez]

Building with Clang 4.0.0 the compiler found this issue:

  ../../Tools/MiniBrowser/gtk/BrowserWindow.c:1175:108: warning: if statement has empty body [-Wempty-body]
      if (gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook)) == 1 && !webkit_web_view_get_uri(webView));
                                                                                                             ^
  ../../Tools/MiniBrowser/gtk/BrowserWindow.c:1175:108: note: put the semicolon on a separate line to silence this warning

The code around this line is, roughly:

    BrowserWindow *window = (BrowserWindow *)windowList->data;
    WebKitWebView *webView = browser_tab_get_web_view(window->activeTab);
    if (gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook)) == 1 && !webkit_web_view_get_uri(webView));
        return webView;

    // Create and return a new web view
    ...

Due to the semicolon in the line containing the conditional, “return webView” in the
following line is always executed, and therefore a new web view is never created.

[Adrian Perez]

Created attachment 311618 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311618 [details]
Patch

Clearing flags on attachment: 311618

Committed r217620: <http://trac.webkit.org/changeset/217620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.