Building with Clang 4.0.0 the compiler found this issue: ../../Tools/MiniBrowser/gtk/BrowserWindow.c:1175:108: warning: if statement has empty body [-Wempty-body] if (gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook)) == 1 && !webkit_web_view_get_uri(webView)); ^ ../../Tools/MiniBrowser/gtk/BrowserWindow.c:1175:108: note: put the semicolon on a separate line to silence this warning The code around this line is, roughly: BrowserWindow *window = (BrowserWindow *)windowList->data; WebKitWebView *webView = browser_tab_get_web_view(window->activeTab); if (gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook)) == 1 && !webkit_web_view_get_uri(webView)); return webView; // Create and return a new web view ... Due to the semicolon in the line containing the conditional, “return webView” in the following line is always executed, and therefore a new web view is never created.
Created attachment 311618 [details] Patch
Comment on attachment 311618 [details] Patch Clearing flags on attachment: 311618 Committed r217620: <http://trac.webkit.org/changeset/217620>
All reviewed patches have been landed. Closing bug.