WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172747
CrashTracer: Regression : com.apple.WebKit.WebContent at STP responsible :: com.apple.WebCore: WebCore::SharedBuffer::data const + 11
https://bugs.webkit.org/show_bug.cgi?id=172747
Summary
CrashTracer: Regression : com.apple.WebKit.WebContent at STP responsible :: c...
Antti Koivisto
Reported
2017-05-31 05:16:36 PDT
8 WebCore: WebCore::SharedBuffer::data() const <== 8 WebCore: WebCore::matchIntegrityMetadata(WebCore::CachedResource const&, WTF::String const&) 8 WebCore: WebCore::HTMLLinkElement::setCSSStyleSheet(WTF::String const&, WebCore::URL const&, WTF::String const&, WebCore::CachedCSSStyleSheet const*) 7 WebCore: WebCore::CachedCSSStyleSheet::checkNotify() | 7 WebCore: WebCore::CachedCSSStyleSheet::finishLoading(WebCore::SharedBuffer*) | 7 WebCore: WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) | 7 WebKit: WebKit::WebResourceLoader::didFinishResourceLoad(WebCore::NetworkLoadMetrics const&) | 7 WebKit: void IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) | 7 WebKit: IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) | 7 WebKit: IPC::Connection::dispatchOneMessage() | 7 JavaScriptCore: WTF::RunLoop::performWork()
Attachments
patch
(4.05 KB, patch)
2017-05-31 10:35 PDT
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
patch
(4.06 KB, patch)
2017-05-31 11:57 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2017-05-31 05:17:02 PDT
<
rdar://problem/32275314
>
Antti Koivisto
Comment 2
2017-05-31 10:35:06 PDT
Created
attachment 311607
[details]
patch
Andreas Kling
Comment 3
2017-05-31 10:49:06 PDT
Comment on
attachment 311607
[details]
patch r=me
Antti Koivisto
Comment 4
2017-05-31 11:57:14 PDT
Created
attachment 311615
[details]
patch
WebKit Commit Bot
Comment 5
2017-05-31 12:11:27 PDT
Comment on
attachment 311615
[details]
patch Clearing flags on attachment: 311615 Committed
r217616
: <
http://trac.webkit.org/changeset/217616
>
WebKit Commit Bot
Comment 6
2017-05-31 12:11:30 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 7
2017-05-31 15:02:54 PDT
Comment on
attachment 311615
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=311615&action=review
> Source/WebCore/loader/SubresourceIntegrity.cpp:190 > + const auto* sharedBuffer = resource.resourceBuffer();
Any reason not to just bail here (or maybe even at the top of the function?
Antti Koivisto
Comment 8
2017-05-31 17:12:51 PDT
Empty body is a valid resource with a valid hash no?
Sam Weinig
Comment 9
2017-06-08 17:10:46 PDT
(In reply to Antti Koivisto from
comment #8
)
> Empty body is a valid resource with a valid hash no?
Indeed. weinig--
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug