Bug 172746 - [CoordinatedGraphics][REGRESSION] Memory hogging since r217214
Summary: [CoordinatedGraphics][REGRESSION] Memory hogging since r217214
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Linux
: P2 Major
Assignee: Gwang Yoon Hwang
Depends on:
Reported: 2017-05-31 00:31 PDT by Claudio Saavedra
Modified: 2017-06-02 02:58 PDT (History)
6 users (show)

See Also:

Patch (6.19 KB, patch)
2017-06-01 08:54 PDT, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2017-06-01 10:40 PDT, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2017-05-31 00:31:21 PDT
To reproduce, run:

  Tools/Scripts/run-webkit-tests --wpe animations/negative-delay.html --iterations=1000

Same with --gtk. Memory usage for WPEWebProcess will go above 1GB very quickly. Reverting that patch makes WPEWebProcess stay at about 35 MB of RAM.

Zan proposed the patch in http://sprunge.us/JBei but with this patch memory usage increases nonetheless to about 100 MB, so there is still something else not being released. I am not familiar with the coordinated graphics code so this is as far as I can go.
Comment 1 Gwang Yoon Hwang 2017-06-01 08:54:37 PDT
Created attachment 311705 [details]
Comment 2 Gwang Yoon Hwang 2017-06-01 10:40:42 PDT
Created attachment 311723 [details]
Comment 3 Gwang Yoon Hwang 2017-06-01 10:41:37 PDT
(In reply to Gwang Yoon Hwang from comment #2)
> Created attachment 311723 [details]
> Patch

Fixed small memory leaks also.
Comment 4 Zan Dobersek 2017-06-02 02:18:03 PDT
Comment on attachment 311723 [details]

Yep, works.
Comment 5 Claudio Saavedra 2017-06-02 02:44:47 PDT
I can't comment as to the patch itself, but I tested it and memory remains under control with it.
Comment 6 WebKit Commit Bot 2017-06-02 02:57:58 PDT
Comment on attachment 311723 [details]

Clearing flags on attachment: 311723

Committed r217707: <http://trac.webkit.org/changeset/217707>
Comment 7 WebKit Commit Bot 2017-06-02 02:58:00 PDT
All reviewed patches have been landed.  Closing bug.