Bug 172724 – convertEnumerationToJS() should not stash ASCIILiteral strings in NeverDestroyed arrays.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Use MAKE_STATIC_STRING_IMPL instead.

<rdar://problem/31193201>

[Mark Lam]

Created attachment 311522 [details]
proposed patch.

[Mark Lam]

Comment on attachment 311522 [details]
proposed patch.

Need to rebase bindings tests.  Will update patch shortly.

[Chris Dumez]

Comment on attachment 311522 [details]
proposed patch.

You will likely need to rebaseline the bindings tests.

[Mark Lam]

Created attachment 311525 [details]
proposed patch w/ bindings tests rebaselined.

[Chris Dumez]

Comment on attachment 311525 [details]
proposed patch w/ bindings tests rebaselined.

r=me

[Joseph Pecoraro]

View in context: https://bugs.webkit.org/attachment.cgi?id=311525&action=review

r=me as well

> Source/WebCore/ChangeLog:17
> +        whose root cause is not known yet.  This patch also adds a release assert to

Nit: One space after a period!

[Mark Lam]

(In reply to Joseph Pecoraro from comment #6)
> > Source/WebCore/ChangeLog:17
> > +        whose root cause is not known yet.  This patch also adds a release assert to
> 
> Nit: One space after a period!

Not in a ChangeLog.  In a ChangeLog, I'm permitted to use the more readable style of 2 spaces between sentences. =)

[Build Bot]

Comment on attachment 311525 [details]
proposed patch w/ bindings tests rebaselined.

Attachment 311525 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3843663

New failing tests:
imported/w3c/web-platform-tests/innerText/getter.html

[Build Bot]

Created attachment 311535 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Mark Lam]

(In reply to Build Bot from comment #8)
> Comment on attachment 311525 [details]
> proposed patch w/ bindings tests rebaselined.
> 
> Attachment 311525 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/3843663
> 
> New failing tests:
> imported/w3c/web-platform-tests/innerText/getter.html

This is not due to my patch.  See https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r217560%20(1262)/results.html.  This issue is already failing in trunk without my patch.

[Mark Lam]

Thanks for the review.  Landed in r217568: <http://trac.webkit.org/r217568>.