Bug 172721 - Use RareData's RenderStyle for display: contents.
Summary: Use RareData's RenderStyle for display: contents.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-30 09:03 PDT by Emilio Cobos Álvarez
Modified: 2017-05-31 05:18 PDT (History)
10 users (show)

See Also:


Attachments
Patch (5.86 KB, patch)
2017-05-30 09:15 PDT, Emilio Cobos Álvarez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (960.23 KB, application/zip)
2017-05-30 10:23 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (875.06 KB, application/zip)
2017-05-30 10:26 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (11.08 MB, application/zip)
2017-05-30 10:51 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.72 MB, application/zip)
2017-05-30 11:00 PDT, Build Bot
no flags Details
Patch (6.38 KB, patch)
2017-05-30 12:40 PDT, Emilio Cobos Álvarez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez 2017-05-30 09:03:50 PDT
It will make some following fixes easier.
Comment 1 Emilio Cobos Álvarez 2017-05-30 09:15:44 PDT
Created attachment 311510 [details]
Patch
Comment 2 Build Bot 2017-05-30 10:23:52 PDT
Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3842742

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html
Comment 3 Build Bot 2017-05-30 10:23:53 PDT
Created attachment 311514 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-05-30 10:26:54 PDT
Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3842745

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html
Comment 5 Build Bot 2017-05-30 10:26:56 PDT
Created attachment 311515 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-05-30 10:51:05 PDT
Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3842760

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html
Comment 7 Build Bot 2017-05-30 10:51:07 PDT
Created attachment 311517 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 8 Build Bot 2017-05-30 11:00:45 PDT
Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3842776

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html
Comment 9 Build Bot 2017-05-30 11:00:46 PDT
Created attachment 311519 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Emilio Cobos Álvarez 2017-05-30 12:40:28 PDT
Created attachment 311528 [details]
Patch
Comment 11 Emilio Cobos Álvarez 2017-05-30 14:08:44 PDT
Hi Antti, could you review this?

This would facilitate the text style stuff, though per our IRC conversation I plan to hold off a bit on doing that. Do you think it's still worth to land something like this?
Comment 12 Antti Koivisto 2017-05-30 23:37:57 PDT
Comment on attachment 311528 [details]
Patch

Looks good, r=me. Now that we have the cached style we can also fix some inefficiencies. For example hasDisplayContents test in shouldResolveElement() won't be needed. This can be done in a separate patch.
Comment 13 Build Bot 2017-05-31 04:49:08 PDT
Comment on attachment 311528 [details]
Patch

Rejecting attachment 311528 [details] from commit-queue.

ecobos@igalia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 14 WebKit Commit Bot 2017-05-31 05:18:27 PDT
Comment on attachment 311528 [details]
Patch

Clearing flags on attachment: 311528

Committed r217599: <http://trac.webkit.org/changeset/217599>
Comment 15 WebKit Commit Bot 2017-05-31 05:18:29 PDT
All reviewed patches have been landed.  Closing bug.