Filling of pullIntoDescriptor from queue is broken.
Created attachment 314608 [details] Patch
Comment on attachment 314608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314608&action=review > Source/WebCore/Modules/streams/ReadableByteStreamInternals.js:509 > + new @Uint8Array(pullIntoDescriptor.buffer).set(new @Uint8Array(headOfQueue.buffer, headOfQueue.byteOffset, bytesToCopy), destStart); Is set safe to use? If Uint8Array prototype is modified, we probably cannot use set directly. We could probably do something like @Uint8Array.prototype.@set.@call(...)
Comment on attachment 314608 [details] Patch Can you verify UInt8Array.set and fix it if necessary
(In reply to youenn fablet from comment #3) > Comment on attachment 314608 [details] > Patch > > Can you verify UInt8Array.set and fix it if necessary I checked @Uint8Array.prototype.@set.@call(...) but it doesn't work, @set cannot be resolved. I tried to fix it in different ways but couldn't, initialization of @Uint8Array and public/private methods wasn't clear to me. As discussed with you, I will land the patch with a FIXME and file a corresponding bug.
Created attachment 329475 [details] Patch
Comment on attachment 329475 [details] Patch Attachment 329475 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5672230 New failing tests: webgl/1.0.2/conformance/context/context-release-with-workers.html webgl/1.0.2/conformance/context/context-release-upon-reload.html
Created attachment 329485 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 329487 [details] Patch
Failure on mac-debug does not seem to be related to this patch.
Comment on attachment 329487 [details] Patch Attachment 329487 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5673590 New failing tests: webgl/1.0.2/conformance/context/context-release-with-workers.html
Created attachment 329489 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Romain Bellessort from comment #9) > Failure on mac-debug does not seem to be related to this patch. Indeed!
Comment on attachment 329487 [details] Patch Rejecting attachment 329487 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 329487, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ted/w3c/ChangeLog fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c' Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c' Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/5674118
Comment on attachment 329487 [details] Patch Clearing flags on attachment: 329487 Committed r226005: <https://trac.webkit.org/changeset/226005>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36091533>