It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send events while the menu is open.
Created attachment 311501 [details] Patch
Comment on attachment 311501 [details] Patch Attachment 311501 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3842034 New failing tests: fast/css/target-fragment-match.html
Created attachment 311504 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Awesome! Just needs approved by an owner.
Ping Alex?
Ping owners?
This seems like it might be good, but I don't understand the implications of this to properly review it. I like that it removes platform-specific code, but will it work correctly on all platforms now? What is correct behavior? Can I verify this manually somehow?
WebPage::contextMenuAtPointInWindow() is only used by WTR, so the fact that all tests keep passing should be enough, IMO.
You're right. r=me
(In reply to Alex Christensen from comment #9) > You're right. r=me Thanks!
Committed r218106: <http://trac.webkit.org/changeset/218106>