Bug 172705 – [css-align] Import W3C web platform tests for the CSS Box Alignment feature

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Javier Fernandez]

This is a meta-bug to track the process of importing the Web Platform Tests in the css-align-3 folder of the W3C github. 

https://github.com/w3c/web-platform-tests/tree/master/css/css-align-3

[Javier Fernandez]

Created attachment 311499 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 311499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311499&action=review

r=me once EWSs are happy.

> LayoutTests/TestExpectations:644
> +# Imported W3C css-align-3 tests that are failing.
> +webkit.org/b/172707 imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-006.html [ Failure ]
> +webkit.org/b/172707 imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-006.html [ Failure ]

I don't think you need those lines, as you're adding the -expected.txt files with FAIL messages these tests will be passing.

And this seems to be the preferred choice, check this comment:
https://bugs.webkit.org/show_bug.cgi?id=170935#c6

So remove these lines from here and the rest looks good.

[youenn fablet]

Comment on attachment 311499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311499&action=review

>> LayoutTests/TestExpectations:644
>> +webkit.org/b/172707 imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-006.html [ Failure ]
> 
> I don't think you need those lines, as you're adding the -expected.txt files with FAIL messages these tests will be passing.
> 
> And this seems to be the preferred choice, check this comment:
> https://bugs.webkit.org/show_bug.cgi?id=170935#c6
> 
> So remove these lines from here and the rest looks good.

Agreed.
Maybe we should have a special way to keep track at the WPT tests we are not passing to improve conformance?
Currently, the best tool is WPT test runner which allows you to select a folder and get a score: https://w3c-test.org/tools/runner/index.html.
Running it locally might be a nice improvement to our infra.

[Javier Fernandez]

Created attachment 311537 [details]
Patch

[Javier Fernandez]

Created attachment 311540 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311540 [details]
Patch

Clearing flags on attachment: 311540

Committed r217575: <http://trac.webkit.org/changeset/217575>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32479638>