Bug 172704 - REGRESSION(r191402?): Safari, Mail crash at com.apple.WebKit: WebKit::WebContextMenuListenerProxy::invalidate + 4
Summary: REGRESSION(r191402?): Safari, Mail crash at com.apple.WebKit: WebKit::WebCont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-30 03:02 PDT by Antti Koivisto
Modified: 2017-05-30 07:06 PDT (History)
7 users (show)

See Also:


Attachments
patch (12.98 KB, patch)
2017-05-30 03:16 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-05-30 03:02:35 PDT
1 com.apple.WebKit               0x001b54fa WebKit::WebContextMenuListenerProxy::invalidate() + 4 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/UIProcess/WebContextMenuListenerProxy.cpp:71)
   2 com.apple.WebKit               0x001b6ff8 WebKit::WebContextMenuProxyMac::showContextMenuWithItems(WTF::Vector<WebKit::WebContextMenuItemData, 0ul, WTF::CrashOnOverflow, 16ul> const&) + 392 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/UIProcess/mac/WebContextMenuProxyMac.mm:470)
   3 com.apple.WebKit               0x001b67d7 WebKit::WebContextMenuProxyMac::showContextMenu() + 829 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/UIProcess/mac/WebContextMenuProxyMac.mm:508)
   4 com.apple.WebKit               0x001b646b WebKit::WebContextMenuProxyMac::show() + 49 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/UIProcess/mac/WebContextMenuProxyMac.mm:332)
   5 com.apple.WebKit               0x00226817 WebKit::WebPageProxy::internalShowContextMenu(WebKit::ContextMenuContextData const&, WebKit::UserData const&) + 295 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/UIProcess/WebPageProxy.cpp:4579)
   6 com.apple.WebKit               0x002266b0 WebKit::WebPageProxy::showContextMenu(WebKit::ContextMenuContextData const&, WebKit::UserData const&) + 38 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/UIProcess/WebPageProxy.cpp:4562)
   7 com.apple.WebKit               0x0023b8d7 void IPC::handleMessage<Messages::WebPageProxy::ShowContextMenu, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&)>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&)) + 106 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/Platform/IPC/HandleMessage.h:40)
   8 com.apple.WebKit               0x000d4459 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 129 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/Platform/IPC/MessageReceiverMap.cpp:123)
   9 com.apple.WebKit               0x002821e0 WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 24 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7603.1.19.1/UIProcess/WebProcessProxy.cpp:482)
Comment 1 Antti Koivisto 2017-05-30 03:16:01 PDT
Created attachment 311498 [details]
patch
Comment 2 Build Bot 2017-05-30 03:17:11 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Andreas Kling 2017-05-30 06:29:30 PDT
Comment on attachment 311498 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2017-05-30 07:02:51 PDT
Comment on attachment 311498 [details]
patch

Clearing flags on attachment: 311498

Committed r217552: <http://trac.webkit.org/changeset/217552>
Comment 5 WebKit Commit Bot 2017-05-30 07:02:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Antti Koivisto 2017-05-30 07:06:36 PDT
<rdar://problem/30057515>